fix(lit): handle TextPart fallback messages in shell and contact sample clients#839
Open
Mindev27 wants to merge 4 commits intogoogle:mainfrom
Open
fix(lit): handle TextPart fallback messages in shell and contact sample clients#839Mindev27 wants to merge 4 commits intogoogle:mainfrom
Mindev27 wants to merge 4 commits intogoogle:mainfrom
Conversation
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Both Lit sample clients (shell, contact) were ignoring TextPart messages
from agent responses. When the agent fails and sends back only a TextPart
fallback, the UI showed a blank screen with no feedback to the user.
Fixed by collecting TextPart in the client response and displaying it
through the existing error UI when no DataPart is available.
This is my first contribution - any feedback on the approach is welcome :)
Fixes #585