refactor: update MCP examples to use StdioConnectionParams #457
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix import path to avoid ImportError - Changed from StdioServerParameters to StdioConnectionParams as recommended.
|
Would be great to get this one merged as this caused some confusion for me also, very basic fix! |
|
@matt-buckley it looks like the adk team made the same changes independently so the main branch shouldn't have this issue. I just merged main into this branch and can't see any difference beyond minor linting/style changes. Closing this due to that. |
|
@andrewginns I believe that's because the merge simply overwrote your changes - the version in |
|
@matt-buckley indeed you're right, I saw they updated the MCP params but the imports haven't been changed. Reopened and updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StdioServerParameters is not recommended. Please use StdioConnectionParams.StdioServerParameterscan't be imported frommcp_toolsetin testing withgoogle-adk>=1.5.0