fix(auth): correct OAuth2 token URL access in refresh flow #116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shifat7
changed the title
|
@polong-lin would love for you to review this change and some feedback. Thanks! |
|
for the issue |
Shifat7
changed the title
Shifat7
changed the title
…thub.com/Shifat7/adk-python into feat/auth/implement-oauth2-token-refresh
|
hi @seanzhou1023, ive updated the PR to use token['refresh_token'] |
|
Thank you so much for the PR and sorry for the delay. However oauth token refreshing is already supported now: . Could you please take a look to see whether there is anything missing ? Feel free to reopen if you see something additional to add. thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added token refresh login inside OAuth2 exchanger