Add news_podcast_agent example demonstrating multi-agent orchestration #3302
Conversation
This example showcases advanced ADK capabilities: - Multi-agent orchestration with specialized agent roles - Gmail API integration for newsletter extraction - Financial data enrichment with yfinance - TLDR-specific parsing for complex newsletter formats - Intelligent content validation using List-ID headers - Error handling with retry logic and exponential backoff Features: - newsletter_podcast_producer: Main orchestrator agent - podcaster_agent: Specialized audio generation agent - Real-time stock price lookup integration - Support for 25+ newsletter sources - 95% newsletter identification accuracy Includes: - README with setup instructions and architecture diagrams - main.py for testing with runner - test_agent.py with unit tests - requirements.txt with dependencies
Summary of ChangesHello @SAMK-online, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new, comprehensive example within the ADK framework, showcasing a multi-agent system designed to transform daily newsletters into engaging podcasts. The system orchestrates several tasks, from fetching and parsing email content to enriching data with financial context and generating multi-speaker audio. It highlights advanced features like robust API integrations, intelligent content processing, and resilient error handling, providing a practical demonstration of complex agent interactions. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new example showcasing multi-agent orchestration for processing Gmail newsletters and generating podcasts. The code includes several new files with agent definitions, utility functions for interacting with the Gmail API, and unit tests. The review focuses on correctness and potential improvements in error handling and code clarity, particularly in the agent.py file.
| Then return the COMPLETE script text so it can be passed to the audio generation agent. | ||
| """, | ||
| tools=[save_news_to_markdown], | ||
| ) |
There was a problem hiding this comment.
There is a syntax error here. A closing parenthesis is missing, which will cause the code to not compile.
| ) | |
| tools=[save_news_to_markdown], | |
| ) |
| wf.writeframes(pcm) | ||
|
|
||
|
|
||
| async def generate_podcast_audio(podcast_script: str, tool_context: ToolContext, filename: str = "'ai_today_podcast") -> Dict[str, str]: |
There was a problem hiding this comment.
The default filename includes a leading quote, which is likely a typo and will cause the file to be named "ai_today_podcast.wav".
It's also recommended to remove the single quotes around the default filename to avoid confusion and ensure the file is named as intended.
| async def generate_podcast_audio(podcast_script: str, tool_context: ToolContext, filename: str = "'ai_today_podcast") -> Dict[str, str]: | |
| async def generate_podcast_audio(podcast_script: str, tool_context: ToolContext, filename: str = "ai_today_podcast") -> Dict[str, str]: |
| if not pathlib.Path(credentials_file).exists(): | ||
| return {"status": "error", "message": "credentials.json file not found. Please download it from Google Cloud Console."} |
There was a problem hiding this comment.
It's good to check if the credentials file exists, but it would be more helpful to provide a more specific error message guiding the user on where to find or how to create this file, especially since this is part of the setup process. Consider including a link to the Google Cloud Console.
Also, consider logging this error to the process_log so that the user can see this error in the report.
| # ** BUG FIX **: This logic now runs for all cases, not just when the extension is added. | ||
| current_directory = pathlib.Path.cwd() | ||
| file_path = current_directory / filename | ||
| wave_file(str(file_path), data) |
There was a problem hiding this comment.
The comment ** BUG FIX **: This logic now runs for all cases, not just when the extension is added. is useful, but it would be even better to explain why this change was necessary. What bug was being fixed, and how does this change address it? This helps future maintainers understand the intent and avoid accidentally reintroducing the bug.
2 participants
This example showcases advanced ADK capabilities:
Features:
Includes:
Please ensure you have read the contribution guide before creating a pull request.
Link to Issue or Description of Change
1. Link to an existing issue (if applicable):
2. Or, if no issue exists, describe the change:
If applicable, please follow the issue templates to provide as much detail as
possible.
Problem:
A clear and concise description of what the problem is.
Solution:
A clear and concise description of what you want to happen and why you choose
this solution.
Testing Plan
Please describe the tests that you ran to verify your changes. This is required
for all PRs that are not small documentation or typo fixes.
Unit Tests:
Please include a summary of passed
pytestresults.Manual End-to-End (E2E) Tests:
Please provide instructions on how to manually test your changes, including any
necessary setup or configuration. Please provide logs or screenshots to help
reviewers better understand the fix.
Checklist
Additional context
Add any other context or screenshots about the feature request here.