Skip to content

Conversation

@jsoref
Copy link
Contributor

@jsoref jsoref commented Nov 4, 2025

This PR corrects misspellings identified by the check-spelling action

Note: while I use tooling to identify errors, the tooling doesn't actually provide the corrections, I'm picking them on my own. I'm a human, and I may make mistakes.

Testing Plan

The misspellings have been reported at https://github.com/jsoref/adk-python/actions/runs/19056081305/attempts/1#summary-54426435973

The action reports that the changes in this PR would make it happy: https://github.com/jsoref/adk-python/actions/runs/19056081446/attempts/1#summary-54426436321

Unit Tests:

  • I have added or updated unit tests for my change.
  • All unit tests pass locally.

Please include a summary of passed pytest results.

Manual End-to-End (E2E) Tests:

Please provide instructions on how to manually test your changes, including any
necessary setup or configuration. Please provide logs or screenshots to help
reviewers better understand the fix.

Checklist

  • I have read the CONTRIBUTING.md document.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have manually tested my changes end-to-end.
  • Any dependent changes have been merged and published in downstream modules.

Additional context

@adk-bot adk-bot added the documentation [Component] This issue is related to documentation, it will be transferred to adk-docs label Nov 4, 2025
@gemini-code-assist
Copy link

Summary of Changes

Hello @jsoref, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the overall quality and consistency of the project by systematically correcting a wide array of spelling, grammar, and punctuation errors. These changes span across documentation, code comments, configuration files, and sample agent definitions, ensuring a more accurate and professional presentation. The effort was supported by automated spelling checks and meticulous manual review, aiming to improve clarity and maintainability throughout the repository.

Highlights

  • Comprehensive Spelling and Grammar Corrections: This pull request addresses and rectifies numerous spelling, grammar, and punctuation errors identified across various files, including documentation, code comments, configuration schemas, and sample agents.
  • Enhanced Readability and Consistency: Improvements were made to ensure consistent terminology and phrasing, such as standardizing 'Github' to 'GitHub', 'Oauth' to 'OAuth', and 'id' to 'ID' where appropriate, leading to a more professional and clearer codebase.
  • Automated Quality Assurance Integration: The corrections were largely driven by findings from the check-spelling action, highlighting the project's commitment to maintaining high code quality through automated tooling and subsequent human review.
  • File Renaming for Accuracy: A test file was renamed from test_evalute_agent_in_fixture.py to test_evaluate_agent_in_fixture.py to correct a misspelling in its filename.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a large number of spelling and minor grammatical corrections across various files, including documentation, source code comments, and test files. The changes are consistent with the PR's goal of fixing misspellings. I've reviewed the modifications, and they are all correct and improve the overall readability and professionalism of the codebase. I have one minor suggestion regarding a duplicated entry in the changelog, but otherwise, the PR is in excellent shape and ready to be merged.

@wuliang229 wuliang229 self-requested a review November 4, 2025 06:52
@hangfei
Copy link
Collaborator

hangfei commented Nov 5, 2025

It's a good contribution but too huge to review.

Let's fix folder by folder. Maybe starting with contributing and tests which are safer. Then go with src etc.

jsoref added 22 commits November 5, 2025 12:30
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
jsoref added 16 commits November 5, 2025 12:30
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
@jsoref jsoref mentioned this pull request Nov 5, 2025
9 tasks
@jsoref jsoref changed the title chore: Fix spelling chore: Fix spelling in src Nov 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation [Component] This issue is related to documentation, it will be transferred to adk-docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants