chore: add missing Apache 2.0 license headers#6155
Closed
milenvk wants to merge 7 commits into
Closed
Conversation
b3d85e7 to
36ec9a0
Compare
Collaborator
|
Hi @milenvk , thanks for your contribution, we explicitly excluded those files from the header check in https://github.com/google/adk-python/blob/main/.github/header-checker-lint.yml Is the policy enforced that even sample config file and js assets need a header? |
Contributor
Author
Yes, the policy enforcement requires them in both YAML and JS files. |
Contributor
Author
|
I have now updated header-checker-lint.yml to also mandate the license headers in the |
copybara-service Bot
pushed a commit
that referenced
this pull request
Jun 22, 2026
Merge #6155 **Please ensure you have read the [contribution guide](https://github.com/google/adk-python/blob/main/CONTRIBUTING.md) before creating a pull request.** ### Link to Issue or Description of Change **1. Link to an existing issue (if applicable):** N/A **2. Or, if no issue exists, describe the change:** **Problem:** The repository is missing Apache 2.0 license headers across 155 files. This is required by Google OSPO. **Solution:** Prepended the standard Apache 2.0 open-source license header to all flagged files. The copyright year was dynamically assigned based on each file's first commit year in git history. ### Testing Plan _Please describe the tests that you ran to verify your changes. This is required for all PRs that are not small documentation or typo fixes._ **Unit Tests:** - [ ] I have added or updated unit tests for my change. - [x] All unit tests pass locally. _Please include a summary of passed `pytest` results._ N/A - This PR only adds comments (license headers) to the top of files and contains zero functional code changes. No new tests are needed, and existing tests should pass as-is. **Manual End-to-End (E2E) Tests:** N/A - No functional code was changed. ### Checklist - [x] I have read the [CONTRIBUTING.md](https://github.com/google/adk-python/blob/main/CONTRIBUTING.md) document. - [x] I have performed a self-review of my own code. - [ ] I have commented my code, particularly in hard-to-understand areas. - [ ] I have added tests that prove my fix is effective or that my feature works. - [x] New and existing unit tests pass locally with my changes. - [ ] I have manually tested my changes end-to-end. - [ ] Any dependent changes have been merged and published in downstream modules. ### Additional context Co-authored-by: Shangjie Chen <deanchen@google.com> COPYBARA_INTEGRATE_REVIEW=#6155 from milenvk:fix-missing-licenses d2a264b PiperOrigin-RevId: 936165783
Collaborator
copybara-service Bot
pushed a commit
that referenced
this pull request
Jun 22, 2026
PR #6155 added the Apache license header to this script but dropped its trailing newline, so the end-of-file-fixer pre-commit hook now fails on every PR. Restore the newline. Co-authored-by: George Weale <gweale@google.com> PiperOrigin-RevId: 936246147
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please ensure you have read the contribution guide before creating a pull request.
Link to Issue or Description of Change
1. Link to an existing issue (if applicable):
N/A
2. Or, if no issue exists, describe the change:
Problem:
The repository is missing Apache 2.0 license headers across 155 files. This is required by Google OSPO.
Solution:
Prepended the standard Apache 2.0 open-source license header to all flagged files. The copyright year was dynamically assigned based on each file's first commit year in git history.
Testing Plan
Please describe the tests that you ran to verify your changes. This is required for all PRs that are not small documentation or typo fixes.
Unit Tests:
Please include a summary of passed
pytestresults.N/A - This PR only adds comments (license headers) to the top of files and contains zero functional code changes. No new tests are needed, and existing tests should pass as-is.
Manual End-to-End (E2E) Tests:
N/A - No functional code was changed.
Checklist
Additional context