Fix long running tool to handle list objects #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes google#63 Fix the `TypeError: cannot pickle 'generator' object` by updating the `LongRunningFunctionTool` and `Runner` class to handle list objects instead of generator objects. * **src/google/adk/tools/long_running_tool.py** - Update `LongRunningFunctionTool` to handle list objects instead of generator objects. - Add `run_async` method to convert generator results to list. * **src/google/adk/tests/unittests/tools/test_long_running_tool.py** - Add unit tests for `LongRunningFunctionTool` to ensure it handles list objects and generator objects properly. * **src/google/adk/tests/unittests/runners/test_runner.py** - Add unit tests for `Runner` class to ensure it accounts for list objects in its `run_async` method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #63
Fix the
TypeError: cannot pickle 'generator' objectby updating theLongRunningFunctionToolandRunnerclass to handle list objects instead of generator objects.src/google/adk/tools/long_running_tool.py
LongRunningFunctionToolto handle list objects instead of generator objects.run_asyncmethod to convert generator results to list.src/google/adk/tests/unittests/tools/test_long_running_tool.py
LongRunningFunctionToolto ensure it handles list objects and generator objects properly.src/google/adk/tests/unittests/runners/test_runner.py
Runnerclass to ensure it accounts for list objects in itsrun_asyncmethod.