Fix handling of escaped variables in llm_flow #90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes google#86 Update `llm_flow` to handle escaped variables correctly and prevent `KeyError`. * **Instructions Handling**: - Add `_replace_escaped` function to handle escaped variables in `src/google/adk/flows/llm_flows/instructions.py`. - Modify `_replace_match` function to differentiate between escaped and non-escaped variables. - Update `instruction_template` to process escaped variables correctly. * **Testing**: - Add test case in `src/google/adk/tests/integration/test_context_variable.py` to verify handling of escaped variables. - Ensure test case covers both escaped and non-escaped variables. - Update existing test cases to use the correct agent.
Collaborator
|
This approach won't work and have side effects. Closing it for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #86
Update
llm_flowto handle escaped variables correctly and preventKeyError.Instructions Handling:
_replace_escapedfunction to handle escaped variables insrc/google/adk/flows/llm_flows/instructions.py._replace_matchfunction to differentiate between escaped and non-escaped variables.instruction_templateto process escaped variables correctly.Testing:
src/google/adk/tests/integration/test_context_variable.pyto verify handling of escaped variables.