chore: adding regex for claude-4 models to anthropic_llm and updating tests #934
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avidelatm
changed the title
avidelatm
force-pushed
the
feature/add-support-for-claude-4-models-to-anthropic_llm
branch
from
87bc58e to
824b437
Compare
avidelatm
changed the title
|
I noticed that the check for conventional commit failed, I didn't see in the contributing readme any mention about using https://www.conventionalcommits.org/en/v1.0.0/ |
|
Please use the "view details", I believe it's the below one. https://github.com/google/adk-python/pull/934/checks?check_run_id=42869792318 |
…ls-to-anthropic_llm
|
@Jacksunwei I don't think I can fix the commit name once it got pushed. should I close this PR, and raise a new one doing the code again but this time using the right `fix:adding-claude-4-to-regex' commit message so the workflow doesn't fail ? |
|
Lm take a look tomorrow. |
Jacksunwei
changed the title
Jacksunwei
approved these changes
May 28, 2025
Jacksunwei
added
the
ready to pull
copybara-service bot
pushed a commit
that referenced
this pull request
May 28, 2025
… tests Copybara import of the project: -- 824b437 by Andres Videla <[email protected]>: Adding regex for claude-4 models to anthropic_llm and updating tests -- 8fa2a2d by Wei Sun (Jack) <[email protected]>: Adds trailing comma. COPYBARA_INTEGRATE_REVIEW=#934 from avidelatm:feature/add-support-for-claude-4-models-to-anthropic_llm 8d10bac PiperOrigin-RevId: 764396694
raflFaisal
pushed a commit
to raflFaisal/adk-python
that referenced
this pull request
May 28, 2025
… tests Copybara import of the project: -- 824b437 by Andres Videla <[email protected]>: Adding regex for claude-4 models to anthropic_llm and updating tests -- 8fa2a2d by Wei Sun (Jack) <[email protected]>: Adds trailing comma. COPYBARA_INTEGRATE_REVIEW=google#934 from avidelatm:feature/add-support-for-claude-4-models-to-anthropic_llm 8d10bac PiperOrigin-RevId: 764396694
|
Merged in 7fc09b2 |
whhlct
pushed a commit
to whhlct/adk-python
that referenced
this pull request
Jun 6, 2025
… tests Copybara import of the project: -- 824b437 by Andres Videla <[email protected]>: Adding regex for claude-4 models to anthropic_llm and updating tests -- 8fa2a2d by Wei Sun (Jack) <[email protected]>: Adds trailing comma. COPYBARA_INTEGRATE_REVIEW=google#934 from avidelatm:feature/add-support-for-claude-4-models-to-anthropic_llm 8d10bac PiperOrigin-RevId: 764396694
coder-aditi
pushed a commit
to coder-aditi/adk-python
that referenced
this pull request
Jul 2, 2025
… tests Copybara import of the project: -- 824b437 by Andres Videla <[email protected]>: Adding regex for claude-4 models to anthropic_llm and updating tests -- 8fa2a2d by Wei Sun (Jack) <[email protected]>: Adds trailing comma. COPYBARA_INTEGRATE_REVIEW=google#934 from avidelatm:feature/add-support-for-claude-4-models-to-anthropic_llm 8d10bac PiperOrigin-RevId: 764396694
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #933
Adding
claude-.*-4.*regex to allow anthropic_llm to use the new claude-sonet-4 and claude-opus-4 models.