Improve Dropdown Behavior in Questionnaire Items #2393
+196
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qaziabubakar-vd
requested review from
santosh-pingle and
a team
as code owners
7 tasks
...c/main/java/com/google/android/fhir/datacapture/views/factories/DropDownViewHolderFactory.kt
Outdated
Show resolved
Hide resolved
...c/main/java/com/google/android/fhir/datacapture/views/factories/DropDownViewHolderFactory.kt
Outdated
Show resolved
Hide resolved
...c/main/java/com/google/android/fhir/datacapture/views/factories/DropDownViewHolderFactory.kt
Outdated
Show resolved
Hide resolved
|
@qaziabubakar-vd Any updates on this PR? Update the PR with the functionality to reset/clear the selected item. |
I was assigned to another project but I will pick this back soon and add the implementation for resetting/clearing the selected item. Will post an update here and on the ticket. |
aditya-07
reviewed
Feb 13, 2024
...c/main/java/com/google/android/fhir/datacapture/views/factories/DropDownViewHolderFactory.kt
Outdated
Show resolved
Hide resolved
…views/factories/DropDownViewHolderFactory.kt Co-authored-by: santosh-pingle <[email protected]>
…' into issue-2228-dropdown-non-editable # Conflicts: # datacapture/src/main/java/com/google/android/fhir/datacapture/views/factories/DropDownViewHolderFactory.kt
… is selected or once user types in some text
…opdown-non-editable # Conflicts: # datacapture/src/main/java/com/google/android/fhir/datacapture/views/factories/DropDownViewHolderFactory.kt
jingtang10
requested changes
Mar 26, 2024
...java/com/google/android/fhir/datacapture/test/views/DropDownViewHolderFactoryEspressoTest.kt
Show resolved
Hide resolved
...c/main/java/com/google/android/fhir/datacapture/views/factories/DropDownViewHolderFactory.kt
Outdated
Show resolved
Hide resolved
...c/main/java/com/google/android/fhir/datacapture/views/factories/DropDownViewHolderFactory.kt
Outdated
Show resolved
Hide resolved
...c/main/java/com/google/android/fhir/datacapture/views/factories/DropDownViewHolderFactory.kt
Outdated
Show resolved
Hide resolved
...c/main/java/com/google/android/fhir/datacapture/views/factories/DropDownViewHolderFactory.kt
Outdated
Show resolved
Hide resolved
|
Hey @qaziabubakar-vd any progress here? Thanks! |
…28-dropdown-non-editable
- Simpler logic - Use `questionnaireViewItem.answers` state to check if the AutoComplete is editable or not - Remove keyListener to make the AutoComplete not editable - Hide keyboard after typing an option then clicking the shown option - Add cool ripple effect on clicking the clear input icon
FikriMilano
force-pushed
the
issue-2228-dropdown-non-editable
branch
from
079ad81 to
a994dc3
Compare
FikriMilano
reviewed
Jan 28, 2025
...c/main/java/com/google/android/fhir/datacapture/views/factories/DropDownViewHolderFactory.kt
Outdated
Show resolved
Hide resolved
|
Remaining todo is test |
FikriMilano
force-pushed
the
issue-2228-dropdown-non-editable
branch
from
814b8ac to
12fb10b
Compare
|
I couldn't add this new demo to the PR description (after refactor), since it's not my PR, but here you go. dropdown-behavior-demo-2.webm |
MJ1998
reviewed
Jan 28, 2025
...java/com/google/android/fhir/datacapture/test/views/DropDownViewHolderFactoryEspressoTest.kt
Outdated
Show resolved
Hide resolved
...c/main/java/com/google/android/fhir/datacapture/views/factories/DropDownViewHolderFactory.kt
Outdated
Show resolved
Hide resolved
|
@jingtang10 @MJ1998 this is ready for review |
ndegwamartin
added a commit
to opensrp/fhircore
that referenced
this pull request
Jan 30, 2025
github-merge-queue bot
pushed a commit
to opensrp/fhircore
that referenced
this pull request
Jan 31, 2025
* Upgrade SDC Version Fixes bug with PR google/android-fhir#2645 * rename Kader Job Aids flavor * Fix typo in add-application-flavors.mdx * Update SDC with google/android-fhir#2393 Fix
dubdabasoduba
pushed a commit
to opensrp/fhircore
that referenced
this pull request
Jan 31, 2025
* Upgrade SDC Version Fixes bug with PR google/android-fhir#2645 * rename Kader Job Aids flavor * Fix typo in add-application-flavors.mdx * Update SDC with google/android-fhir#2393 Fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes # #2228
Description
Improved the dropdown behaviour, disabled the search within the field once an option is selected.
Once the text is cleared, showed the list of options again in the dropdown
Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?
Type
Choose one: Bug fix
Screenshots (if applicable)
Checklist
./gradlew spotlessApplyand./gradlew spotlessCheckto check my code follows the style guide of this project../gradlew checkand./gradlew connectedCheckto test my changes locally.