Add support for additional data during CQL evaluation

[ndegwamartin]

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #2419

Description
#2419

Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?

Type
Feature

Screenshots (if applicable)

Checklist

• I have read and acknowledged the Code of conduct.
• I have read the Contributing page.
• I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
• I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
• I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
• I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
• I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

[MJ1998]

Why not add this parameter additionalData to this API itself:-

fun evaluateLibrary(
    libraryUrl: String,
    patientId: String?,
    parameters: Parameters?,
    expressions: Set<String>?,
  ): IBaseParameters {

[MJ1998]

Please also run ./gradlew spotlessapply

[ndegwamartin]

Why not add this parameter additionalData to this API itself:-

fun evaluateLibrary(
    libraryUrl: String,
    patientId: String?,
    parameters: Parameters?,
    expressions: Set<String>?,
  ): IBaseParameters {

I'd figured this'd be a breaking change, but I suppose this is actually okay since we are still in alpha

[ndegwamartin]

@MJ1998 additionally the the method is heavily overloaded in the same class so just added the new one. I've pushed an update that refactors it in line with the implementation of the other overloads.

[MJ1998]

@ktarasenko @jingtang10
Can you take a look at this? Thanks

[jingtang10]

this seems like a legitimate change. but @brynrhodes can you please comment on the usage of additional data here? or @ndegwamartin can you please add some background on why this is necessary, what's the difference with prefetch data etc etc?

thanks!

[jingtang10]

Thanks @ndegwamartin!

[ndegwamartin]

@vitorpamplona any idea why the Benchmarking tests would fail here?

[ndegwamartin]

@vitorpamplona any idea why the Benchmarking tests would fail here?

nvm, figured out the issue