Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial GitHub Codespaces (AKA Dev Container) configuration (see #2481) #2482

Merged
merged 6 commits into from
Apr 17, 2024
Merged

Initial GitHub Codespaces (AKA Dev Container) configuration (see #2481) #2482

merged 6 commits into from
Apr 17, 2024

Conversation

vorburger
Copy link
Member

see #2481

@jingtang10 & @santosh-pingle how about this?

@vorburger vorburger requested review from santosh-pingle and a team as code owners March 15, 2024 22:32
@vorburger vorburger force-pushed the vorburger-codespaces branch 2 times, most recently from 7d7007d to 4d8c8dc Compare March 15, 2024 22:48
@vorburger vorburger marked this pull request as draft March 15, 2024 22:53
@vorburger vorburger mentioned this pull request Mar 15, 2024
Closed
@vorburger vorburger force-pushed the vorburger-codespaces branch from 2210366 to a333b4d Compare March 16, 2024 00:32
@vorburger vorburger mentioned this pull request Mar 16, 2024
Closed
@vorburger vorburger marked this pull request as ready for review March 18, 2024 13:44
@vorburger vorburger requested a review from MJ1998 March 18, 2024 15:58
jingtang10
jingtang10 approved these changes Mar 25, 2024
View reviewed changes
Copy link
Collaborator

@jingtang10 jingtang10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whilst i think this is a great change, i think we need to document a little better in our codebase why we're using this and how. especially how other developers (and developers in our wider community) can benefit from this. @vorburger please feel free to merge this. but can you think about adding a bit more documentation either in here or as an immediate follow-up? thanks :)

@vorburger vorburger force-pushed the vorburger-codespaces branch from d045670 to 6877caf Compare April 17, 2024 12:14
@vorburger
Copy link
Member Author

whilst i think this is a great change, i think we need to document a little better in our codebase why we're using this and how. especially how other developers (and developers in our wider community) can benefit from this. @vorburger please feel free to merge this. but can you think about adding a bit more documentation either in here or as an immediate follow-up? thanks :)

ACK, done in new commit 6877caf (still in this PR); I'll merge this now.

@vorburger vorburger enabled auto-merge (squash) April 17, 2024 12:19
@vorburger vorburger merged commit 6ff0643 into master Apr 17, 2024
4 checks passed
@vorburger vorburger deleted the vorburger-codespaces branch April 17, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jingtang10 jingtang10 jingtang10 approved these changes

@santosh-pingle santosh-pingle Awaiting requested review from santosh-pingle

@divyaramnath-13 divyaramnath-13 Awaiting requested review from divyaramnath-13 divyaramnath-13 was automatically assigned from google/android-fhir

@MJ1998 MJ1998 Awaiting requested review from MJ1998

Assignees
No one assigned
Labels
None yet
Projects
Android FHIR SDK
Status: Complete
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vorburger @jingtang10