Skip to content

Conversation

@BenHenning
Copy link
Contributor

@BenHenning BenHenning commented Oct 29, 2025

The basics

The details

Resolves

Fixes #9301
Fixes #9312
Fixes #9313
Fixes part of #9304

Proposed Changes

This introduces a variety of specific changes to resolve several issues for screen reader work, including introducing fundamental support for field labeling.

Specifically:

Reason for Changes

This PR is largely being used as a basis for one particularly significant issue: #9301. Field labeling has undergone several iterations over the past few months and the team seems comfortable sticking with a "do as little as possible" approach when determining the label, thus justifying the need for expecting more specific customization (i.e. #9450). To this end it's important to be clear that getting fields to a good state is not actually "done" but the need to track it as a large incomplete thing has ended. Note that one important part of #9301 was updating field plugins to be accessible--this largely seems unnecessary as-is as it will be completely dependent on the needs of future user tests. The long-term plan will need to account for making all fields in blockly-samples accessible (per #9307).

Some of the terminology used here (e.g. for bubbles) will likely need to change after user testing, but it's important to establish that something correct is communicated even if the terminology may require scaffolding and/or refinement.

It's important to note that while non-clickable field images are no longer in the node graph, their ARIA presence still exists as part of the fluent block labeling solution. That is, FieldImage's alt text is used as part of constructing a fluent block label (sometimes to confusing effect--see #9452).

Test Coverage

No tests needed since these are experimental changes and do not change existing test behaviors.

Documentation

No documentation changes are needed for these experimental changes.

Additional Information

None.

Copy link
Contributor Author

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finished self-review.

@BenHenning BenHenning marked this pull request as ready for review November 4, 2025 22:46
@BenHenning BenHenning requested a review from a team as a code owner November 4, 2025 22:46
@BenHenning BenHenning requested review from maribethb and removed request for a team November 4, 2025 22:46
@github-actions github-actions bot added PR: fix Fixes a bug and removed PR: fix Fixes a bug labels Nov 4, 2025
@BenHenning
Copy link
Contributor Author

This is a bit smaller of a change so I decided not to add a video. However if that is especially important for review I am happy to make one @maribethb.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: fix Fixes a bug

Projects

None yet

2 participants