Skip to content

Conversation

@cnaples79
Copy link
Contributor

@cnaples79 cnaples79 commented Sep 27, 2025

Summary

  • ignore metadata lines such as duid and vendorclass when parsing the leases file
  • return a sentinel error so the collector quietly skips these records instead of logging parse failures
  • add regression coverage and sample data to demonstrate that metadata lines are skipped while lease metrics remain unchanged

Fixes #33

Copy link
Member

@ferrarimarco ferrarimarco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR. Looping @stapelberg in for an additional review.

@stapelberg stapelberg merged commit 2849316 into google:main Sep 29, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

duid formatted leases throw error

3 participants