Repository navigation
fix(go): restore dependency scanning and fork CI - #634
Open
rksharma-owg wants to merge 4 commits into
Open
rksharma-owg wants to merge 4 commits into
rksharma-owg wants to merge 4 commits into
Conversation
Update x/text to the release fixing GO-2026-5970 and refresh golangci-lint for current stable Go export data. Build validation tools with the required compiler while preserving the supported test matrix.
Resolve the explicit head branch in its owning repository so fork pull requests can run the tidy check. Keep the existing branch checkout and release-please token behavior for same-repository contributions.
Select the pull request head repository for its explicit branch while retaining the workflow repository on push events. Preserve same-repository release-please credentials and commit behavior.
Pin the changed workflows to verified action commits and update changed-files to its first fixed release. Scope write access to the tidy job that pushes release-please updates while retaining read access for all other Go checks.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Go checks report GO-2026-5970 through
x/text, and the pinned linter cannot read export data from the stable Go compiler selected by CI. The tidy and Bazel jobs also request a fork's head branch from the base repository, where that branch does not exist. The required Actions scan flags the old changed-files version, mutable action references and workflow-wide write permissions.This change:
x/textto 0.39.0 while retaining the Go 1.25 minimum, and builds golangci-lint 2.14.0 with the selected compiler.Validation:
e47c49c8d1ed312828f75e102e4406e67d2fad5b, hosted Go 1.25/1.26 builds, tests and vulnerability scans passed, along with stable-Go formatting, tidy, vet, race, lint, license and TODO checks. Bazel Java 17/21 builds and all 57 tests per job passed. The unchanged baseline reproduced the scanner and linter failures. Full source validation.f79a8b193947d199e1037c30b86a90cbcfa80889, exact fork checkout, tidy, stable-Go lint, and Java 17/21 Maven pin/unchanged-lock checks passed. Same-repository release-please and actual push-event controls passed. The fixed changed-files action produced the expected Go/lint matches and unrelated-path exclusion. Workflow validation.e47c49c, rather than being repeated atf79a8b1.$GITHUB_OUTPUTdiagnostics on the original and candidate Go/Bazel workflows; the new checkout inputs and pins introduce no diagnostics.Upstream workflow approval remains required; approval-held upstream checks are not reported as passed.