Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed an NPE when parsing malformed subjects #1291

Merged
merged 3 commits into from
Mar 11, 2025
Merged

Conversation

bashir2
Copy link
Collaborator

@bashir2 bashir2 commented Feb 7, 2025

Description of what I changed

See the added unit-test for an example malformed subject that triggers this.

E2E test

TESTED:

Added unit-test to reproduce the reported issue.

Checklist: I completed these to help reviewers :)

  • I have read and will follow the review process.

  • I am familiar with Google Style Guides for the language I have coded in.

    No? Please take some time and review Java and Python style guides.

  • My IDE is configured to follow the Google code styles.

    No? Unsure? -> configure your IDE.

  • I have added tests to cover my changes. (If you refactored existing code that was well tested you do not have to add tests)

  • I ran mvn clean package right before creating this pull request and added all formatting changes to my commit.

  • All new and existing tests passed.

  • My pull request is based on the latest changes of the master branch.

    No? Unsure? -> execute command git pull --rebase upstream master

@codecov-commenter
Copy link

codecov-commenter commented Feb 7, 2025

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 50.74%. Comparing base (c2356c8) to head (759da3c).

Files with missing lines Patch % Lines
...java/com/google/fhir/analytics/FetchResources.java 71.42% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1291      +/-   ##
============================================
- Coverage     50.76%   50.74%   -0.03%     
- Complexity      692      693       +1     
============================================
  Files            90       90              
  Lines          5726     5725       -1     
  Branches        775      776       +1     
============================================
- Hits           2907     2905       -2     
- Misses         2533     2535       +2     
+ Partials        286      285       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@chandrashekar-s chandrashekar-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bashir2 for fixing this bug.

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@bashir2 bashir2 merged commit 786480e into google:master Mar 11, 2025
8 checks passed
@bashir2 bashir2 deleted the subjectNPE branch March 11, 2025 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants