[Depends on #8332] Integrate fgviewer to the engine side
#8344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poweifeng
approved these changes
Jan 14, 2025
show50726
force-pushed
the
dev/fginfo-conversion
branch
from
6b0cfc9 to
ccc4f8a
Compare
pixelflinger
approved these changes
Jan 17, 2025
pixelflinger
requested changes
Jan 17, 2025
There was a problem hiding this comment.
just use mCameCase for member variable name. Also see
https://github.com/google/filament/blob/main/CODE_STYLE.md
For code style to follow.
other than that, LGTM.
# Conflicts: # libs/fgviewer/include/fgviewer/DebugServer.h # libs/fgviewer/include/fgviewer/FrameGraphInfo.h # libs/fgviewer/src/FrameGraphInfo.cpp
I updated the naming, thanks for the reminder! PTAL. |
pixelflinger
approved these changes
Jan 31, 2025
# Conflicts: # filament/src/details/Engine.cpp
show50726
added a commit
that referenced
this pull request
Feb 15, 2025
…8379) * Introduce FrameGraphInfo class * Move the assignment into pimpl * Make ctors explicit * Add ctors to fg info structs * Revert the macro change to align with existing * Address the comments * Remove pimpl and move func def to .cc * Fix * Convert the FrameGraph to FrameGraphInfo * Initialize and update debug server on engine side * Fix compile error * Address the comments * Update * Use camelCase * Use camelCase * Update * Add JsonWriter to convert fginfo to json * Add getStatus api and implement it * Add increment * Implement GET apis * Fix compile error * Update * Use c_str_safe * Add operator== for FrameGraphInfo * Call updateFrameGraph in appropriate locations * Address the comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should be merged after #8332 is in.
In this PR, I intergrate the fgviewer to the filament engine side, right now the engine will update the framegraph info to the debug server every frame.
FrameGraph::getFrameGraphInfomethod to convert current state tofgviewer::FrameGraphInfofgviewer::DebugServermember to theEngineclass and initialize it as the engine loop startsfgviewer::DebugServerand unregister it as it gets terminatedRenderer::renderJobafterFrameGraphis compiled