Error message on failed write #8822
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
python
c++
grpc
codegen
aardappel
reviewed
Dec 4, 2025
| const char* RealFileSaver::AttemptSave(const char* name, const char* buf, | ||
| size_t len, bool binary) { | ||
| if (!SaveFile(name, buf, len, binary)) { | ||
| static std::string error_msg; |
Collaborator
There was a problem hiding this comment.
I don't think we can have static std::string in this project. This will make the project non-modular in terms of memory management. Better to stick an err string in RealFileSaver ? Or, if we absolutely must do string formatting for these errors, probably the least bad would be to return a std::string by value from this function, where empty string means no error. But really, you are formatting name which is passed in by the called, so they already know the cause of the problem, so a non-formatted const char * may be better.
Contributor
Author
There was a problem hiding this comment.
fair point i will update 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on previews MR #8764 and returns proper error message when files fail to write.
eg something like this:
//cc @jtdavis777 @aardappel