This repository was archived by the owner on Jun 30, 2025. It is now read-only.
docs: give a example to show how to import glog by add_subdirectory #1067
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Closed
sergiud
suggested changes
Jan 22, 2024
README.rst
Outdated
| project by replacing the :cmake:`find_package` call from the previous snippet by | ||
| :cmake:`add_subdirectory`. The :cmake:`glog::glog` target is in this case an | ||
| :cmake:`ALIAS` library target for the ``glog`` library target. | ||
| Here is an example which using :cmake:`FetchContent` and :cmake:`add_subdirectory` |
There was a problem hiding this comment.
Do we really need to show a complete example for how to use FetchContent? This is essentially an exact mirror of the example from CMake reference documentation. In that sense, a single sentence with a link to FetchContent example should be sufficient.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: I2e77e155c134d36f36ff38f3d3bc396a48b07ff6