mysql/awsmysql: migrate to use otelsql.OpenDB() for wrap the connector
#3626
+130
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allow us to use `mysql.NewConnector()` directly
giautm
changed the title
otelsql.OpenDB() for wrap the connector
|
cc @vangent to review both PRs. Thank you, |
|
It would be helpful if you could update the PR description to explain what you are trying to accomplish. Is this a refactoring with no change in behavior? Are you fixing a bug? ...? |
Updated the description. |
|
Added simple Otel test. |
giautm
force-pushed
the
g/awsmysql-otelsql
branch
from
5d09ce9 to
2cb2685
Compare
giautm
force-pushed
the
g/awsmysql-otelsql
branch
from
2cb2685 to
2a92009
Compare
vangent
approved these changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
otelsql.OpenDB()andotelsql.WrapDriver()has the same effect. This also avoids a copy oftraceOptspassing around the connector.mysql.NewConnector()to open the connection: It has two points: No need to callFormatDSN()and ask the MySQL driver parse it again to the config object. It also allow the PR mysql/awsmysql: pass TLS directly to the config #3627 pass the TLS config to the underlying driver.