Skip to content

fix(ping): fix auto detect service scheme issue #2166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+36 −0
Open

fix(ping): fix auto detect service scheme issue #2166

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
67a65b8
fix(ping): fix auto detect service scheme issue
derekhjray Nov 15, 2025
d3646ce
feat(ping): add ping fixture testcase
derekhjray Nov 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions pkg/v1/remote/transport/ping.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,12 @@ func pingSingle(ctx context.Context, reg name.Registry, t http.RoundTripper, sch
resp.Body.Close()
}()

// Check actual registry scheme detected, in case of redirecting to different scheme,
// update the scheme so subsequent logic (and the returned Challenge) reflects it.
if resp.Request != nil && resp.Request.URL != nil && resp.Request.URL.Scheme != "" {
scheme = resp.Request.URL.Scheme
}

insecure := scheme == "http"

switch resp.StatusCode {
Expand Down