Skip to content

Conversation

@maishivamhoo123
Copy link

This PR addresses #3859
by updating the BypassActors field in RepositoryRuleset to use the Go 1.24 omitzero JSON tag:

BypassActors []*BypassActor json:"bypass_actors,omitzero"

What this does:

Differentiates between an unset array and an empty array.

Simplifies the API by removing the need for workaround functions to clear BypassActors.

All existing tests pass successfully.

Note:

script/lint.sh and script/generate.sh may still report warnings due to duplicate operations in the generated metadata.

These issues are upstream and unrelated to the changes in this PR.

Looking forward to guidance from maintainers on handling the metadata and lint warnings.

@gmlewis gmlewis changed the title feat : Use omitzero for BypassActors to support empty arrays (#3859) feat: Use omitzero for BypassActors to support empty arrays (#3859) Dec 9, 2025
@codecov
Copy link

codecov bot commented Dec 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.37%. Comparing base (06ab3a2) to head (9dd332a).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3869      +/-   ##
==========================================
- Coverage   92.40%   92.37%   -0.03%     
==========================================
  Files         200      200              
  Lines       14382    14327      -55     
==========================================
- Hits        13289    13234      -55     
  Misses        894      894              
  Partials      199      199              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant