Replace eventlog logic to go-eventlog #591
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/gcbrun |
Remove tcg eventlog logic in server/eventlog, use go-eventlog instead. Update go-tdx-guest package Add VerifyOpts.AllowEmptySBVar, which is an opt in go-eventlog Add FirmwareLogState -> MachineState conversion func and tests Signed-off-by: Jiankun Lu <[email protected]>
jkl73
force-pushed
the
changeeventlog
branch
from
44ee116 to
efa498f
Compare
|
/gcbrun |
alexmwu
reviewed
Sep 11, 2025
| Digest: event.Digest, | ||
| DigestVerified: bytes.Equal(digest, event.Digest), | ||
| } | ||
| func convertToPbDatabase(cert *gepb.Database) *pb.Database { |
There was a problem hiding this comment.
cert should be named db or gedb
| if bytes.HasPrefix(grubCmd, prefix) { | ||
| return len(prefix) | ||
| func matchWellKnownCert(cert *gepb.Certificate) (pb.WellKnownCertificate, error) { | ||
| if cert.GetWellKnown() != gepb.WellKnownCertificate_UNKNOWN { |
There was a problem hiding this comment.
nit: invert this if statement and return early to avoid nesting two conditionals
| return convertToMachineState(tpmfirmwarestate) | ||
| } | ||
|
|
||
| func convertToMachineState(tpmfirmwarestate *gepb.FirmwareLogState) (*pb.MachineState, error) { |
There was a problem hiding this comment.
consider exporting this, as it is already implemented in google3
@yawangwang FYI
| case gepb.GCEConfidentialTechnology_AMD_SEV_SNP: | ||
| return pb.GCEConfidentialTechnology_AMD_SEV_SNP | ||
| default: | ||
| return pb.GCEConfidentialTechnology_NONE |
There was a problem hiding this comment.
return an error by default
| } | ||
| } | ||
|
|
||
| var efiState *pb.EfiState |
There was a problem hiding this comment.
Please add support for https://github.com/google/go-eventlog/blob/main/proto/state.proto#L176-L181 here or create an issue
| }, | ||
| } | ||
|
|
||
| func TestParseEventLogs(t *testing.T) { |
There was a problem hiding this comment.
I know these are copied over to go-eventlog, but it would be good to keep these tests to ensure the output is still the same despite the conversion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove tcg eventlog logic in server/eventlog, use go-eventlog instead.
Update go-tdx-guest package
Add VerifyOpts.AllowEmptySBVar, which is an opt in go-eventlog Add FirmwareLogState -> MachineState conversion func and tests