Skip to content

Refactor container runner to not depend on file system or use a real timer #602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Refactor container runner to not depend on file system or use a real timer #602

wants to merge 1 commit into from
+304 −190

Conversation

@JoshuaKrstic
Copy link
Contributor

This PR was broken out from this PR: #560

This PR:

  • Refactors the container runner goroutine starting to make it more testable and remove race conditions
  • Adds time based utilities to test the container runner better
  • Adds missing tests to our container runner

Refactor container runner to not depend on file system or use a real …
5f0aacd 
…timer

Add test for the wellknownfilewriter
@JoshuaKrstic
Copy link
Contributor Author

/gcbrun

yawangwang
yawangwang approved these changes Oct 16, 2025
View reviewed changes
Copy link
Collaborator

@yawangwang yawangwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Contingent approval on successful cloud build tests

@alexmwu alexmwu mentioned this pull request Oct 23, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yawangwang yawangwang yawangwang approved these changes

@alexmwu alexmwu Awaiting requested review from alexmwu

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JoshuaKrstic @yawangwang