Skip to content

Conversation

@jxu023
Copy link

@jxu023 jxu023 commented Oct 28, 2025

This fixes the attestation failures for parsing v4 attestation reports.

@jkl73
Copy link
Contributor

jkl73 commented Oct 28, 2025

/gcbrun

Copy link
Contributor

@alexmwu alexmwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you run go mod tidy?

@jxu023
Copy link
Author

jxu023 commented Oct 29, 2025

Have you run go mod tidy?

Oh, I hadn't before; I've now re-uploaded after running go mod tidy

@alexmwu
Copy link
Contributor

alexmwu commented Oct 29, 2025

/gcbrun

@alexmwu
Copy link
Contributor

alexmwu commented Oct 29, 2025

Hmm, the cloud build is still failing with

Step #0: go: updates to go.mod needed; to update it:

  | Step #0: go mod tidy

@jkl73
Copy link
Contributor

jkl73 commented Oct 29, 2025

probably because the launcher and verifier are nested modules (they have their own go.mod), need to run mod tidy in those seperately:

cd ./launcher
go mod tidy

cd ../verifier
go mod tidy

@jxu023
Copy link
Author

jxu023 commented Oct 29, 2025

probably because the launcher and verifier are nested modules (they have their own go.mod), need to run mod tidy in those seperately:

re-uploaded with more tidying

@alexmwu
Copy link
Contributor

alexmwu commented Oct 29, 2025

/gcbrun

@jkl73
Copy link
Contributor

jkl73 commented Oct 30, 2025

hmm not sure why proto is blocking, try to follow the steps in proto/doc.go

This fixes the attestation failures for parsing v4 attestation reports.
@jxu023
Copy link
Author

jxu023 commented Oct 30, 2025

hmm not sure why proto is blocking, try to follow the steps in proto/doc.go

looks like that might be the cause here since we see

--- a/proto/attest/attest.pb.go
+++ b/proto/attest/attest.pb.go
@@ -1,6 +1,6 @@
 // Code generated by protoc-gen-go. DO NOT EDIT.
 // versions:
-//     protoc-gen-go v1.31.0
+//     protoc-gen-go v1.36.10
 //     protoc        v3.21.12

re-uploaded after running the go generate command, and mod tidying in all 4 dirs with go.mod files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants