Skip to content

Update docs: assertions are thread-safe on desktop Windows #5103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cindykrafft wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update docs: assertions are thread-safe on desktop Windows #5103

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions docs/advanced.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -787,8 +787,6 @@ EXPECT_NO_FATAL_FAILURE({
});
```

Assertions from multiple threads are currently not supported on Windows.

#### Checking for Failures in the Current Test

`HasFatalFailure()` in the `::testing::Test` class returns `true` if an
Expand Down Expand Up @@ -1550,9 +1548,6 @@ well, use one of the following macros instead:
EXPECT_NONFATAL_FAILURE_ON_ALL_THREADS(statement, substring);
```

{: .callout .note}
NOTE: Assertions from multiple threads are currently not supported on Windows.

For technical reasons, there are some caveats:

1. You cannot stream a failure message to either macro.
Expand Down
10 changes: 5 additions & 5 deletions docs/primer.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -474,9 +474,9 @@ NOTE: `ParseGUnitFlags()` is deprecated in favor of `InitGoogleTest()`.
## Known Limitations

* Google Test is designed to be thread-safe. The implementation is thread-safe
on systems where the `pthreads` library is available. It is currently
*unsafe* to use Google Test assertions from two threads concurrently on
other systems (e.g. Windows). In most tests this is not an issue as usually
the assertions are done in the main thread. If you want to help, you can
volunteer to implement the necessary synchronization primitives in
on systems where the `pthreads` library is available and on desktop
Windows. It is currently *unsafe* to use Google Test assertions from two
threads concurrently on other systems. In most tests this is not an issue as
usually the assertions are done in the main thread. If you want to help, you
can volunteer to implement the necessary synchronization primitives in
`gtest-port.h` for your platform.
Loading