fix(death-tests): escape ':' and '-' in threadsafe child filters - #5108
Open
rwinkelman wants to merge 2 commits into
Open
rwinkelman wants to merge 2 commits into
rwinkelman wants to merge 2 commits into
Conversation
Typed-test names like std::string put ':' into --gtest_filter, which splits patterns so the child matches nothing and death tests falsely pass. Escape filter metacharacters and parse filters with unescaped delimiters only. Fixes google#5105
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Threadsafe (and Windows/Fuchsia) death tests re-exec the binary with
--gtest_filter=<suite>.<name>. Filter syntax treats:as a pattern separator and-as the start of a negative filter, so typed-test names likestd::stringnever match. The child exits 0 without running the statement; the parent treats a missing status byte asDIED, so non-dying death tests pass.\\,:, and-when building the death-test filter flag--gtest_filterwith escape-aware splits on:and-Fixes #5105
Test plan
GetNamereturning"std::string"failsEXPECT_EXITthat does not exit (statement runs)"int"still passes/fails as before