Skip to content

Add JUnit tests for JsonArray Class - #1532

Merged
eamonnmcmanus merged 3 commits into
google:mainfrom
Phhofm:jsonarray_testcoverage
Sep 14, 2026
Merged

eamonnmcmanus merged 3 commits into
google:mainfrom
Phhofm:jsonarray_testcoverage

Conversation

@Phhofm

@Phhofm Phhofm commented May 14, 2019

Copy link
Copy Markdown
Contributor

Added tests so that class-coverage is 100%

Before:
image

Now:
image

Added tests so that class-coverage is 100%
@lyubomyr-shaydariv

Copy link
Copy Markdown
Contributor
  1. It would be nice to have your branches rebased onto the latest upstream branches (the master is currently at 49d8630).
  2. Also, it would be very nice to have the whitespaces preserved:
    • git diff --stat Phhofm/jsonarray_testcoverage~1..Phhofm/jsonarray_testcoverage currently produces 1 file changed, 357 insertions(+), 74 deletions(-)
    • but git diff --stat --ignore-all-space Phhofm/jsonarray_testcoverage~1..Phhofm/jsonarray_testcoverage produces 1 file changed, 285 insertions(+), 2 deletions(-)

@google-cla google-cla Bot added cla: no and removed cla: yes labels Sep 13, 2026
@eamonnmcmanus

Copy link
Copy Markdown
Member

@Phhofm, if you're still interested in making this change, can you sign the CLA? (I'm not sure why the system said that you had and then that you hadn't.)

@google-cla google-cla Bot added cla: yes and removed cla: no labels Sep 14, 2026
@Phhofm

Phhofm commented Sep 14, 2026

Copy link
Copy Markdown
Contributor Author

@Phhofm, if you're still interested in making this change, can you sign the CLA? (I'm not sure why the system said that you had and then that you hadn't.)

Done, CLA check passed now :)

@eamonnmcmanus eamonnmcmanus left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@eamonnmcmanus
eamonnmcmanus merged commit 8fe0778 into google:main Sep 14, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants