Added ModArith::LiftOp#3066
Merged
copybara-service[bot] merged 1 commit intoJun 15, 2026
Merged
Conversation
j2kun
reviewed
Jun 13, 2026
| ); | ||
| let results = (outs SignlessIntegerLike:$output); | ||
| let hasVerifier = 1; | ||
| let assemblyFormat = "$lift_type $input attr-dict `:` type($input) `->` type($output)"; |
Collaborator
There was a problem hiding this comment.
LGTM, but you may find it useful to add a simple lit test just to make sure the syntax pretty-prints how you want it to.
j2kun
approved these changes
Jun 13, 2026
j2kun
left a comment
j2kun
left a comment
Collaborator
There was a problem hiding this comment.
This won't get merged until Monday anyway, so I will wait until then to label it as pull_ready.
crockeea
force-pushed
the
modarithExtractToLift
branch
from
c60adb6 to
a43e264
Compare
Collaborator
Author
|
Tests added. |
j2kun
approved these changes
Jun 13, 2026
j2kun
added
the
pull_ready
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
ModArith::LiftOp. A future PR will removeModArith::ExtractOpand replace all uses of it.