Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement campaign identifiers #145

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jmistral-google
Copy link

No description provided.

Copy link

@baohle-google baohle-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Left a comment regarding the docstring for getCampaignLabelResourceByName, but otherwise looks great.

* Retrieves the campaign label resource name for the provided label name.
*
* @param customerId
* @param labelName

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT: Include return value in docstring

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants