Remove Bazel module dependency on rules_jsonnet #1200
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rules_jsonnet Although rules_jsonnet is the appropriate Bazel module for external Jsonnet users to use for their Jsonnet build actions, using it internally within the jsonnet repo itself is actually a little difficult as it creates a mutually recursive dependency. Since the only thing it's being used for is the jsonnet_json_test rule, and we have scripts to runs such tests anyway, it's relatively easy to define our own jsonnet_json_golden_test rule and avoid the recursive dependency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This starts with the commits from #1189, and adds commits to remove the Bazel module dependency on rules_jsonnet.
Although rules_jsonnet is the appropriate Bazel module for external Jsonnet users to use for their Jsonnet build actions, using it internally within the jsonnet repo itself is actually a little difficult as it creates a mutually recursive dependency.
Since the only thing it's being used for is the jsonnet_json_test rule, and we have scripts to runs such tests anyway, it's relatively easy to define our own jsonnet_json_golden_test rule and avoid the recursive dependency.
Our current import of rules_jsonnet points to a very old commit which is no longer compatible with current versions of Bazel, so my first attempt here was to just upgrate to the most recent rules_jsonnet release (0.6.0), however I then ran into difficulties of rules_jsonnet wanting to pull in jsonnet itself (which I don't want because the tests need to test the jsonnet binary built from the local workspace).