Libphonenumber JS API is not able to parse numbers with missing '+' u…

…nlike Java.
google · Dec 17, 2024 · fba6a38 · fba6a38
1 parent 4246175
commit fba6a38
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 1 deletion.
diff --git a/javascript/i18n/phonenumbers/phonenumberutil.js b/javascript/i18n/phonenumbers/phonenumberutil.js
@@ -3852,7 +3852,7 @@ i18n.phonenumbers.PhoneNumberUtil.prototype.maybeExtractCountryCode =
       var generalDesc = defaultRegionMetadata.getGeneralDesc();
       /** @type {!RegExp} */
       var validNumberPattern =
-          new RegExp(generalDesc.getNationalNumberPatternOrDefault());
+          new RegExp('^(?:' + generalDesc.getNationalNumberPatternOrDefault() + ')$');
       // Passing null since we don't need the carrier code.
       this.maybeStripNationalPrefixAndCarrierCode(
           potentialNationalNumber, defaultRegionMetadata, null);

diff --git a/javascript/i18n/phonenumbers/phonenumberutil_test.js b/javascript/i18n/phonenumbers/phonenumberutil_test.js
@@ -2758,6 +2758,24 @@ function testMaybeExtractCountryCode() {
   } catch (e) {
     fail('Should not have thrown an exception: ' + e.toString());
   }
+  number = new i18n.phonenumbers.PhoneNumber();
+  try {
+    phoneNumber = '821064588888';
+    metadata  = phoneUtil.getMetadataForRegion(RegionCode.KR);
+    countryCallingCode = 82;
+    numberToFill = new goog.string.StringBuffer();
+    assertEquals(
+        'Should have extracted the country calling code of the ' +
+            'region passed in',
+        countryCallingCode,
+        phoneUtil.maybeExtractCountryCode(
+            phoneNumber, metadata, numberToFill, true, number));
+    assertEquals(
+        'Did figure out CountryCodeSource correctly',
+        CCS.FROM_NUMBER_WITHOUT_PLUS_SIGN, number.getCountryCodeSource());
+  } catch (e) {
+    fail('Should not have thrown an exception: ' + e.toString());
+  }
 }
 
 function testParseNationalNumber() {