Transition deps from requirements.txt to pyproject.toml #111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jshin1394
approved these changes
Oct 15, 2025
jeffcarp
force-pushed
the
no-reqs
branch
21 times, most recently
from
e3b7025 to
38d84de
Compare
Only deps in pyproject.toml are included when installing with `pip`. This caused `clu` and other libraries to not be installed. Fixes google#110.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only deps in pyproject.toml are included when installing with
pip. This causedcluand other libraries to not be included when installinggoogle-metrax(#110).This PR deletes both
requirements.txtfiles and merges all deps into pyproject.toml, which is current best practice:https://packaging.python.org/en/latest/guides/writing-pyproject-toml/#dependencies-and-requirements
Fixes #110.