Fix bug in list_differ (#7)

google · Nov 17, 2016 · 5d9eec7 · 5d9eec7
1 parent f85fdf2
commit 5d9eec7
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,7 @@
+## 0.15.0+2
+
+* Fix a bug in `ListDiffer` that caused a `RangeError`
+
 ## 0.15.0+1
 
 * Fix analysis errors caused via missing `/*<E>*/` syntax in `0.15.0`

diff --git a/lib/src/differs/list_differ.dart b/lib/src/differs/list_differ.dart
@@ -210,7 +210,7 @@ List<ListChangeRecord/*<E>*/ > _calcSplices/*<E>*/(
   }
 
   if (currentStart == currentEnd) {
-    final spliceRemoved = old.sublist(oldStart, oldStart + oldEnd);
+    final spliceRemoved = old.sublist(oldStart, oldStart + (oldEnd - oldStart));
     return [
       new ListChangeRecord/*<E>*/ .remove(
         current,

diff --git a/pubspec.yaml b/pubspec.yaml
@@ -1,5 +1,5 @@
 name: observable
-version: 0.15.0+1
+version: 0.15.0+2
 author: Dart Team <[email protected]>
 description: Support for marking objects as observable
 homepage: https://github.com/dart-lang/observable