Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enterprise Linux 8 package installation simplification #221

Merged
merged 2 commits into from
Apr 3, 2025

Conversation

simonpane
Copy link
Collaborator

Simplify package installation for Enterprise Linux 8 based systems, removing redundant tasks and unused package repo file checks.

Also, minor formatting adjustments of when: keys for related tasks to align with the best practice of using multiple lines with multiple "and" conditions.

@simonpane simonpane requested a review from mfielding March 7, 2025 01:21
@simonpane simonpane self-assigned this Mar 7, 2025
Copy link
Member

@mfielding mfielding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a huge fan of simplification... thanks! Are there any cases we want to test other than the built-in RHEL8 one?

package:
name: "{{ oracle_required_rpms + vars['oracle_required_rpms_el' + ansible_distribution_major_version] }}"
state: present
lock_timeout: "{{ pkg_mgr_lock_timeout }}"
loop: "{{ repo_files }}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we now only use repo_files for RHEL7, should we skip the steps to calculate it in non-RHEL7 cases? Maybe even a block?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's a very good suggestion @mfielding . Have implemented as you suggested in commit 18dcc14 - moved all RHEL7 specific steps into a dedicated block.

Re-tested against all major versions with results shown in:

@google-oss-prow google-oss-prow bot added size/L and removed size/M labels Mar 28, 2025
Copy link
Member

@mfielding mfielding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mfielding, simonpane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mfielding mfielding merged commit 7f067af into google:master Apr 3, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants