Enterprise Linux 8 package installation simplification#221
Enterprise Linux 8 package installation simplification#221mfielding merged 2 commits intogoogle:masterfrom
Conversation
mfielding
left a comment
mfielding
left a comment
There was a problem hiding this comment.
I'm a huge fan of simplification... thanks! Are there any cases we want to test other than the built-in RHEL8 one?
| name: "{{ oracle_required_rpms + vars['oracle_required_rpms_el' + ansible_distribution_major_version] }}" | ||
| state: present | ||
| lock_timeout: "{{ pkg_mgr_lock_timeout }}" | ||
| loop: "{{ repo_files }}" |
There was a problem hiding this comment.
If we now only use repo_files for RHEL7, should we skip the steps to calculate it in non-RHEL7 cases? Maybe even a block?
There was a problem hiding this comment.
Yes, that's a very good suggestion @mfielding . Have implemented as you suggested in commit 18dcc14 - moved all RHEL7 specific steps into a dedicated block.
Re-tested against all major versions with results shown in:
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mfielding, simonpane The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
2 participants
Simplify package installation for Enterprise Linux 8 based systems, removing redundant tasks and unused package repo file checks.
Also, minor formatting adjustments of
when:keys for related tasks to align with the best practice of using multiple lines with multiple "and" conditions.