Ansible task to query and output Oracle DBID after creation

[sahsagar-google]

The change involves modifying the config-db.yml Ansible playbook to capture and log the Oracle DBID after a database is created. This information can help in Day 2 operations such as backup and patching. SQLPlus is used here for the query and PR #280 helps push playbook events to Google Cloud Logging.

Buganizer: b/424254827

[google-oss-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sahsagar-google
Once this PR has been reviewed and has the lgtm label, please assign alexbasinov for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[AlexBasinov]

FYI The single-instance-on-bms presubmit test failed with the following error:

TASK [Gathering Facts] *********************************************************
fatal: [g322234287-s002]: FAILED! => {"msg": "The field 'environment' has an invalid value, which includes an undefined variable. The error was: 'oracle_home' is undefined"}

DBID reporting is needed only for WLM-triggered deployments on GCE. Could you please update the Ansible task to skip BMS?

[AlexBasinov]

could you please provide a sample log entry with the JSON structure that contains the extracted DBID?

[sahsagar-google]

could you please provide a sample log entry with the JSON structure that contains the extracted DBID?

Here is the output from the oracle-toolkit-install-single-instance-on-bms job

PLAY [Get and Log Oracle DBID for All Databases] *******************************
TASK [Gathering Facts] *********************************************************
ok: [g322234287-s002]
TASK [Execute SQL query to get DBID] *******************************************
ok: [g322234287-s002]
TASK [Extract DBID from query result] ******************************************
ok: [g322234287-s002]
TASK [Output DBID for Cloud Logging pipeline (example for stdout)] *************
ok: [g322234287-s002] => {
"msg": "ORACLE_DBID: 1734014694"
}

[mfielding]

Do we need to change this? It gets confusing as we, say, define oracleHome in one file and grid_home in another.

[sahsagar-google]

The vars defined here are lower in precedence from group_vars/all.yml which are applied to all tasks and hosts. So, without moving these variables the tasks are failing citing that the env variables are not available yet.
That could also be because the dependent variables (mentioned here) are not available.
If it is confusing, I could move all related variables to group_vars/all.yml. Please let me know your thoughts?

[mfielding]

Even if they're lower in precedence, I think they should be available; can you check how we're referencing this in other playbooks? Having removed the environment references from the top-level playbooks, we may not even need to move these references at all.