feat(os/rpm): allow building on macOS #1324
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
G-Rath
force-pushed
the
rpm-macos
branch
5 times, most recently
from
291c22b to
c26be09
Compare
G-Rath
changed the title
G-Rath
force-pushed
the
rpm-macos
branch
3 times, most recently
from
d627ba5 to
c26be09
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extractor should work fine on macOS 🤷
In theory it should also work fine on Windows, but currently the tests run into issues with cleaning up directories due to "files being used by other processes" that I've not been able to resolve, so have left that for another PR