refactor: enable ineffassign and wastedassign linters
#289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
G-Rath
changed the title
wastedassign linterineffassign and wastedassign linters
erikvarga
approved these changes
Dec 3, 2024
|
Looks like there's a merge conflict, can you rebase? |
G-Rath
force-pushed
the
linting/enable-wastedassign
branch
from
7ef91a4 to
d7d9b73
Compare
G-Rath
force-pushed
the
linting/enable-wastedassign
branch
from
d7d9b73 to
38e611f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables linters for ensuring that the result of assignments are actually used - I'm not actually sure of the difference between the two, but they both seem to be enabled by default and very quick, so I don't think it's a huge issue to have both
Relates to #274