Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add transitive extraction for Maven pom.xml #399
base: main
Are you sure you want to change the base?
feat: add transitive extraction for Maven pom.xml #399
Changes from 9 commits
dee5fa9
cdff15f
cf22342
3cede05
84fc579
6533f01
4a5099b
db0dd1d
c931bc8
5213257
1492083
71492ea
4606350
7ec576e
08f4c03
75871ac
a9a9d54
5a9d20c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a lot of code in Extract, I wonder if we could move some of these into separate functions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolving Maven pom.xml requires a lot of steps and some of these steps are already done in packages (e.g.
deps.dev/util/maven
).Considering we are moving over the Maven guided remediation logic here, we may consider do some refactoring later to see if possible to reduce duplication.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair enough - in that case maybe we should add a TODO with a link to an issue about doing that refactoring later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops, I missed this comment - will add a TODO