Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update output and add HTML output as an option in the output.md doc. #1541

Merged
merged 6 commits into from
Jan 29, 2025

Conversation

another-rex
Copy link
Collaborator

Several small changes:

  • Update the output doc to include HTML output
  • Update Feedback link to point to the correct feedback discussion
  • Clarify the error logging message to warn people to update osv-scanner if base image scanning fails.
  • Actually fail base image scanning to avoid spamming people with the log.

docs/output.md Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Jan 28, 2025

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 69.17%. Comparing base (3ee976e) to head (a5766db).

Files with missing lines Patch % Lines
...ts/clientimpl/baseimagematcher/baseimagematcher.go 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1541      +/-   ##
==========================================
- Coverage   69.18%   69.17%   -0.02%     
==========================================
  Files         200      200              
  Lines       18988    18989       +1     
==========================================
- Hits        13137    13135       -2     
- Misses       5141     5143       +2     
- Partials      710      711       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

docs/output.md Outdated Show resolved Hide resolved
@another-rex another-rex merged commit b175847 into google:main Jan 29, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants