Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change module name to v2 #1546

Merged
merged 2 commits into from
Jan 29, 2025
Merged

Conversation

michaelkedar
Copy link
Member

Go requires major version 2 of a package to be under a /v2 module.

Per https://go.dev/doc/modules/major-version, must change the go.mod file and all references to github.com/google/osv-scanner to github.com/google/osv-scanner/v2 for our v2 release.

@michaelkedar
Copy link
Member Author

I've left github.com/google/osv-scanner/experimental/javareach alone, since it's its own go module. Not sure if I should rename it to v2 anyway?

@michaelkedar michaelkedar requested a review from hogo6002 January 29, 2025 23:37
@codecov-commenter
Copy link

codecov-commenter commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.18%. Comparing base (e670e6c) to head (d8a2d1a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1546      +/-   ##
==========================================
+ Coverage   69.01%   69.18%   +0.17%     
==========================================
  Files         200      200              
  Lines       18989    18989              
==========================================
+ Hits        13105    13138      +33     
+ Misses       5169     5141      -28     
+ Partials      715      710       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oliverchang
Copy link
Collaborator

I've left github.com/google/osv-scanner/experimental/javareach alone, since it's its own go module. Not sure if I should rename it to v2 anyway?

this is a temporary thing anyway. so totally fine to leave it alone.

Copy link
Collaborator

@oliverchang oliverchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for fixing this!

@michaelkedar michaelkedar merged commit 2821e79 into google:main Jan 29, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants