Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cmd): add experimental config support to image command #1547

Merged
merged 5 commits into from
Feb 4, 2025

Conversation

hogo6002
Copy link
Contributor

No description provided.

@hogo6002 hogo6002 requested a review from another-rex January 30, 2025 00:36
@codecov-commenter
Copy link

codecov-commenter commented Jan 30, 2025

Codecov Report

Attention: Patch coverage is 72.34043% with 26 lines in your changes missing coverage. Please review.

Project coverage is 69.35%. Comparing base (b870d62) to head (0b39f6e).

Files with missing lines Patch % Lines
cmd/osv-scanner/internal/helper/helper.go 60.65% 17 Missing and 7 partials ⚠️
cmd/osv-scanner/scan/image/main.go 87.50% 1 Missing ⚠️
cmd/osv-scanner/scan/source/main.go 96.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1547      +/-   ##
==========================================
+ Coverage   69.30%   69.35%   +0.05%     
==========================================
  Files         200      200              
  Lines       19041    19059      +18     
==========================================
+ Hits        13196    13219      +23     
+ Misses       5138     5133       -5     
  Partials      707      707              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@another-rex another-rex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can the code here be shared with scan source? I think most of this overlaps

Copy link
Collaborator

@another-rex another-rex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, 1 small comment

@hogo6002 hogo6002 requested a review from another-rex February 4, 2025 04:11
@another-rex another-rex merged commit 5d239bf into google:main Feb 4, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants