Fix PageLoaderElement.innerText doc.
#167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Change `text content` => `inner text` (textContent is a different element property) * Update link
mk13
reviewed
Nov 28, 2018
| /// https://developer.mozilla.org/en-US/docs/Web/API/Node/innerText), but | ||
| /// behaviour may vary for the different pageloader implementations. | ||
| /// This should return the value of | ||
| /// [`<element>.innerText`](https://developer.mozilla.org/en-US/docs/Web/API/HTMLElement/innerText), |
There was a problem hiding this comment.
Please fix this to be within the 80-length limit. I believe the markdown should still work.
mk13
reviewed
Nov 28, 2018
| /// This should return the value of webdriver's getText() call (see | ||
| /// http://seleniumhq.github.io/selenium/docs/api/java/org/openqa/selenium/WebElement.html#getText--), | ||
| /// This should return the value of webdriver's | ||
| /// [`getText()`](http://seleniumhq.github.io/selenium/docs/api/java/org/openqa/selenium/WebElement.html#getText--), |
There was a problem hiding this comment.
Improved, but I don't want to split the URL without a way to test it; do you know of one?
There was a problem hiding this comment.
I don't know of a way. Let's just leave it as it is then.
mk13
approved these changes
Nov 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
text content=>inner text(textContent is a different element property)Part of #166