Spelling #1
Draft
Spelling #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
jsoref
commented
Jan 29, 2025
| //! | ||
| //! Write a single byte synchronously to the display. Use this | ||
| //! sparingly, as it will tie up the micro duing the write. | ||
| //! sparingly, as it will tie up the micro during the write. |
There was a problem hiding this comment.
This could be doing. All of my corrections are manual and this is an example where I picked one possible correction over another.
Thinking about it for a third time, it seems likely doing is the right word...
| } else { | ||
| PBL_LOG(LOG_LEVEL_DEBUG, | ||
| "Error: read max14690 whomai byte 0x%x, expecting 0x%x", val, 0x01); | ||
| "Error: read max14690 whoami byte 0x%x, expecting 0x%x", val, 0x01); |
There was a problem hiding this comment.
It's possible that whomai is some magical term of art, but I'm going it's just a typo.
| the 'Flash imaging tools' section. | ||
| - docs/spi_flash_imaging.txt: A document describing the protocol | ||
| used to load load data onto Pebble's SPI flash via | ||
| used to load data onto Pebble's SPI flash via |
There was a problem hiding this comment.
Spell checking tools have complained about duplicate words for decades, and this is an example of such a correction. There are a couple of words that I left because they seemed to have value when repeated, but this just felt like an error.
There was a problem hiding this comment.
The tool checks the names of file paths.
The corresponding reference is changed in resources/normal/base/resource_map.json #1 (comment)
Pebble_50x50_Day_
-seperator
+separator
.svg| "Types are defined below with the following parameters: ", | ||
| " name: The name of the type as it appears in our codebase. This type definition must ", | ||
| " be visibile in one of the headers in the headers list below. ", | ||
| " be visible in one of the headers in the headers list below. ", |
There was a problem hiding this comment.
I generally try to fix up whitespace where it seems likely to matter, but I missed this case.
| @@ -605,7 +605,7 @@ void test_graphics_fill_circle_${BIT_DEPTH_NAME}__radial_precise(void){ | |||
| // Drawing | |||
| setup_test_aa_sw(&ctx, fb, ORIGIN_RECT_NO_CLIP, ORIGIN_RECT_NO_CLIP, true, 1); | |||
| graphics_fill_radial_precise_internal(&ctx, center, radius_inner, radius_outer, angle_start, angle_end); | |||
| cl_check(gbitmap_pbi_eq(&ctx.dest_bitmap, "fill_radial_origin_aa_precise_halfs_letter_c.${BIT_DEPTH_NAME}.pbi")); | |||
| cl_check(gbitmap_pbi_eq(&ctx.dest_bitmap, "fill_radial_origin_aa_precise_halves_letter_c.${BIT_DEPTH_NAME}.pbi")); | |||
There was a problem hiding this comment.
These files are renamed #1 (comment) #1 (comment)
| @@ -108,7 +108,7 @@ void test_phone_formatting__overflowing_first_name(void) { | |||
| char dest[NAME_LENGTH]; | |||
| memset(dest, GUARD_CHAR, NAME_LENGTH); | |||
|
|
|||
| phone_format_caller_name("Pankajavalli Balamarugan", dest, buffer_length); | |||
| phone_format_caller_name("Pankajavalli Balamurugan", dest, buffer_length); | |||
There was a problem hiding this comment.
Notable... I'm pretty sure this was a dev.
There was a problem hiding this comment.
Reference is renamed #1 (comment)
There was a problem hiding this comment.
Reference is renamed #1 (comment)
| @@ -377,8 +377,8 @@ def print_graph(x): | |||
| print "\n############ INPUT ######################" | |||
| print_graph(input) | |||
|
|
|||
| print "\n############ GAUSIAN OF INPUT ############" | |||
| # input = apply_gausian(input, 0.1) | |||
| print "\n############ GAUSSIAN OF INPUT ############" | |||
There was a problem hiding this comment.
This does change the width of a thing, but this line was already wider than the INPUT line, so I didn't think it was worth removing trailing #s.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I understand that this repository may not be ready for contributions, but here's a round of changes...
There are a couple of commits with
(?)that i'm less sure about.This PR corrects misspellings identified by the check-spelling action
The misspellings have been reported at https://github.com/jsoref/pebble/actions/runs/13024954424#summary-36332391887
The action reports that the changes in this PR would make it happy:
https://github.com/jsoref/pebble/actions/runs/13024956111#summary-36332395838