Skip to content

Add Exit Setup button to splash screen. #11523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 21, 2025
Merged

Add Exit Setup button to splash screen. #11523

merged 4 commits into from
Oct 21, 2025

Conversation

@abdelmalekkkkk
Copy link
Collaborator

@abdelmalekkkkk abdelmalekkkkk commented Sep 23, 2025 •
edited by hussain-t
Loading

Summary

Addresses issue:

Relevant technical choices

PR Author Checklist

  • My code is tested and passes existing unit tests.
  • My code has an appropriate set of unit tests which all pass.
  • My code is backward-compatible with WordPress 5.2 and PHP 7.4.
  • My code follows the WordPress coding standards.
  • My code has proper inline documentation.
  • I have added a QA Brief on the issue linked above.
  • I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

Do not alter or remove anything below. The following sections will be managed by moderators only.

Code Reviewer Checklist

  • Run the code.
  • Ensure the acceptance criteria are satisfied.
  • Reassess the implementation with the IB.
  • Ensure no unrelated changes are included.
  • Ensure CI checks pass.
  • Check Storybook where applicable.
  • Ensure there is a QA Brief.
  • Ensure there are no unexpected significant changes to file sizes.

Merge Reviewer Checklist

  • Ensure the PR has the correct target branch.
  • Double-check that the PR is okay to be merged.
  • Ensure the corresponding issue has a ZenHub release assigned.
  • Add a changelog message to the issue.

@github-actions
Copy link

github-actions bot commented Sep 23, 2025 •
edited
Loading

Build files for 6c84f1f have been deleted.

@github-actions
Copy link

github-actions bot commented Sep 23, 2025 •
edited
Loading

Size Change: +3.65 kB (+0.17%)

Total Size: 2.17 MB

Filename Size Change
./dist/assets/js/googlesitekit-splash-********************.js 72.2 kB +3.65 kB (+5.33%) 🔍
ℹ️ View Unchanged
Filename Size Change
./dist/assets/blocks/reader-revenue-manager/block-editor-plugin/editor-styles.css 124 B 0 B
./dist/assets/blocks/reader-revenue-manager/block-editor-plugin/editor-styles.js 20 B 0 B
./dist/assets/blocks/reader-revenue-manager/block-editor-plugin/index.js 42.7 kB 0 B
./dist/assets/blocks/reader-revenue-manager/common/editor-styles.css 307 B 0 B
./dist/assets/blocks/reader-revenue-manager/common/editor-styles.js 20 B 0 B
./dist/assets/blocks/reader-revenue-manager/contribute-with-google/index.js 5.88 kB 0 B
./dist/assets/blocks/reader-revenue-manager/contribute-with-google/non-site-kit-user.js 5.07 kB 0 B
./dist/assets/blocks/reader-revenue-manager/subscribe-with-google/index.js 5.88 kB 0 B
./dist/assets/blocks/reader-revenue-manager/subscribe-with-google/non-site-kit-user.js 5.07 kB 0 B
./dist/assets/blocks/sign-in-with-google/editor-styles.css 84 B 0 B
./dist/assets/blocks/sign-in-with-google/editor-styles.js 20 B 0 B
./dist/assets/blocks/sign-in-with-google/index.js 17.8 kB 0 B
./dist/assets/css/googlesitekit-admin-css-********************.min.css 63.6 kB 0 B
./dist/assets/css/googlesitekit-adminbar-css-********************.min.css 11.7 kB 0 B
./dist/assets/css/googlesitekit-authorize-application-css-********************.min.css 846 B 0 B
./dist/assets/css/googlesitekit-wp-dashboard-css-********************.min.css 8.43 kB 0 B
./dist/assets/js/146-********************.js 963 B 0 B
./dist/assets/js/201-********************.js 2.85 kB 0 B
./dist/assets/js/314-********************.js 100 kB 0 B
./dist/assets/js/315-********************.js 3.08 kB 0 B
./dist/assets/js/379-********************.js 3.7 kB 0 B
./dist/assets/js/590-********************.js 1.89 kB 0 B
./dist/assets/js/640-********************.js 2.36 kB 0 B
./dist/assets/js/909-********************.js 1.01 kB 0 B
./dist/assets/js/analytics-advanced-tracking-********************.js 475 B 0 B
./dist/assets/js/googlesitekit-activation-********************.js 24 kB 0 B
./dist/assets/js/googlesitekit-ad-blocking-recovery-********************.js 54.8 kB 0 B
./dist/assets/js/googlesitekit-adminbar-********************.js 34.4 kB 0 B
./dist/assets/js/googlesitekit-api-********************.js 7.79 kB 0 B
./dist/assets/js/googlesitekit-block-tracking-********************.js 5.51 kB 0 B
./dist/assets/js/googlesitekit-components-********************.js 5.74 kB +4 B (+0.07%)
./dist/assets/js/googlesitekit-consent-mode-********************.js 25.5 kB 0 B
./dist/assets/js/googlesitekit-data-********************.js 1.7 kB 0 B
./dist/assets/js/googlesitekit-datastore-forms-********************.js 6.99 kB 0 B
./dist/assets/js/googlesitekit-datastore-location-********************.js 1.51 kB 0 B
./dist/assets/js/googlesitekit-datastore-site-********************.js 17.3 kB 0 B
./dist/assets/js/googlesitekit-datastore-ui-********************.js 7.11 kB 0 B
./dist/assets/js/googlesitekit-datastore-user-********************.js 22.8 kB 0 B
./dist/assets/js/googlesitekit-entity-dashboard-********************.js 61.5 kB 0 B
./dist/assets/js/googlesitekit-events-provider-contact-form-7-********************.js 1.75 kB 0 B
./dist/assets/js/googlesitekit-events-provider-easy-digital-downloads-********************.js 745 B 0 B
./dist/assets/js/googlesitekit-events-provider-mailchimp-********************.js 1.74 kB 0 B
./dist/assets/js/googlesitekit-events-provider-ninja-forms-********************.js 1.66 kB 0 B
./dist/assets/js/googlesitekit-events-provider-optin-monster-********************.js 1.69 kB 0 B
./dist/assets/js/googlesitekit-events-provider-popup-maker-********************.js 1.76 kB 0 B
./dist/assets/js/googlesitekit-events-provider-woocommerce-********************.js 1.13 kB 0 B
./dist/assets/js/googlesitekit-events-provider-wpforms-********************.js 1.74 kB 0 B
./dist/assets/js/googlesitekit-i18n-********************.js 6.16 kB 0 B
./dist/assets/js/googlesitekit-key-metrics-setup-********************.js 42 kB 0 B
./dist/assets/js/googlesitekit-main-dashboard-********************.js 131 kB 0 B
./dist/assets/js/googlesitekit-metric-selection-********************.js 52.6 kB 0 B
./dist/assets/js/googlesitekit-modules-********************.js 19.8 kB 0 B
./dist/assets/js/googlesitekit-modules-ads-********************.js 47.5 kB 0 B
./dist/assets/js/googlesitekit-modules-adsense-********************.js 123 kB 0 B
./dist/assets/js/googlesitekit-modules-analytics-4-********************.js 185 kB 0 B
./dist/assets/js/googlesitekit-modules-pagespeed-insights-********************.js 23.5 kB 0 B
./dist/assets/js/googlesitekit-modules-reader-revenue-manager-********************.js 43.5 kB 0 B
./dist/assets/js/googlesitekit-modules-search-console-********************.js 65.2 kB 0 B
./dist/assets/js/googlesitekit-modules-sign-in-with-google-********************.js 33.2 kB 0 B
./dist/assets/js/googlesitekit-modules-tagmanager-********************.js 30 kB 0 B
./dist/assets/js/googlesitekit-notifications-********************.js 66 kB 0 B
./dist/assets/js/googlesitekit-polyfills-********************.js 230 B 0 B
./dist/assets/js/googlesitekit-settings-********************.js 124 kB 0 B
./dist/assets/js/googlesitekit-user-input-********************.js 45.9 kB 0 B
./dist/assets/js/googlesitekit-vendor-********************.js 322 kB 0 B
./dist/assets/js/googlesitekit-widgets-********************.js 103 kB 0 B
./dist/assets/js/googlesitekit-wp-dashboard-********************.js 59.1 kB 0 B
./dist/assets/js/runtime-********************.js 1.93 kB 0 B

compressed-size-action

@abdelmalekkkkk abdelmalekkkkk force-pushed the enhancement/11337-add-exit-setup-to-splash branch from 5955662 to 5174824 Compare October 8, 2025 15:56
@abdelmalekkkkk
Copy link
Collaborator Author

abdelmalekkkkk commented Oct 9, 2025

The CI failures seem unrelated.

hussain-t
hussain-t requested changes Oct 20, 2025
View reviewed changes
Copy link
Collaborator

@hussain-t hussain-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @abdelmalekkkkk, can you please resolve the conflicts and send it back to CR? Thanks!

@abdelmalekkkkk abdelmalekkkkk force-pushed the enhancement/11337-add-exit-setup-to-splash branch from c08dcdc to 74838ea Compare October 20, 2025 15:07
@github-actions
Copy link

github-actions bot commented Oct 20, 2025

Storybook is ready:

@abdelmalekkkkk
Copy link
Collaborator Author

abdelmalekkkkk commented Oct 20, 2025

Thanks @hussain-t! The test failure is unrelated. Back to you.

hussain-t
hussain-t reviewed Oct 21, 2025
View reviewed changes
assets/js/components/setup/SetupUsingProxyWithSignIn/ExitSetup.js Outdated
@@ -0,0 +1,48 @@
/**
* Header component for ExitSetup.
Copy link
Collaborator

@hussain-t hussain-t Oct 21, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be "ExitSetup component for SetupUsingProxyWithSignIn". I'll make the changes myself.

Suggested change
* Header component for ExitSetup.
* ExitSetup component.

hussain-t
hussain-t approved these changes Oct 21, 2025
View reviewed changes
Copy link
Collaborator

@hussain-t hussain-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @abdelmalekkkkk! LGTM 👍

@hussain-t hussain-t merged commit 000fb43 into develop Oct 21, 2025
25 checks passed
@hussain-t hussain-t deleted the enhancement/11337-add-exit-setup-to-splash branch October 21, 2025 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hussain-t hussain-t hussain-t approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@abdelmalekkkkk @hussain-t