Skip to content

Conversation

@ankitrox
Copy link
Collaborator

@ankitrox ankitrox commented Sep 29, 2025

Summary

Addresses issue:

Relevant technical choices

PR Author Checklist

  • My code is tested and passes existing unit tests.
  • My code has an appropriate set of unit tests which all pass.
  • My code is backward-compatible with WordPress 5.2 and PHP 7.4.
  • My code follows the WordPress coding standards.
  • My code has proper inline documentation.
  • I have added a QA Brief on the issue linked above.
  • I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

Do not alter or remove anything below. The following sections will be managed by moderators only.

Code Reviewer Checklist

  • Run the code.
  • Ensure the acceptance criteria are satisfied.
  • Reassess the implementation with the IB.
  • Ensure no unrelated changes are included.
  • Ensure CI checks pass.
  • Check Storybook where applicable.
  • Ensure there is a QA Brief.
  • Ensure there are no unexpected significant changes to file sizes.

Merge Reviewer Checklist

  • Ensure the PR has the correct target branch.
  • Double-check that the PR is okay to be merged.
  • Ensure the corresponding issue has a ZenHub release assigned.
  • Add a changelog message to the issue.

Copy link
Collaborator

@nfmohit nfmohit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your work on this, @ankitrox. I've left a question for you. Feel free to let me know if there are any questions/concerns, thanks!

Copy link
Collaborator

@nfmohit nfmohit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work, thank you @ankitrox!

I've left two small comments for your review. Please let me know what you think.

I've also fixed the test failures as otherwise, merging this PR would result in test failures in develop.

@ankitrox
Copy link
Collaborator Author

ankitrox commented Oct 6, 2025

Thanks @nfmohit

That's a nice suggestion to have a separate bash file. I've added it and sending your way for another look.

Copy link
Collaborator

@nfmohit nfmohit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @ankitrox!

Note: I've moved the bash file to the tests/js/bin directory and added an environment variable for the Jest results file to avoid repetition.

@nfmohit nfmohit merged commit bd4aed5 into develop Oct 7, 2025
10 checks passed
@nfmohit nfmohit deleted the insfrastructure/11305-failed-suites-retries branch October 7, 2025 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants