-
Notifications
You must be signed in to change notification settings - Fork 326
Fix: Failed JS test suites ignored in retries #11562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your work on this, @ankitrox. I've left a question for you. Feel free to let me know if there are any questions/concerns, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work, thank you @ankitrox!
I've left two small comments for your review. Please let me know what you think.
I've also fixed the test failures as otherwise, merging this PR would result in test failures in develop.
…com:google/site-kit-wp into insfrastructure/11305-failed-suites-retries.
|
Thanks @nfmohit That's a nice suggestion to have a separate bash file. I've added it and sending your way for another look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you @ankitrox!
Note: I've moved the bash file to the tests/js/bin directory and added an environment variable for the Jest results file to avoid repetition.
Summary
Addresses issue:
Relevant technical choices
PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist