Enhancement/11889 server pagination#12242
Merged
Conversation
zutigrm
commented
Feb 26, 2026
|
Storybook is ready:
|
|
Build files for 5da33fd have been deleted. |
|
Size Change: +367 B (+0.02%) Total Size: 2.3 MB ℹ️ View Unchanged
|
zutigrm
commented
Mar 2, 2026
| /** | ||
| * Internal dependencies | ||
| */ | ||
| import { useDebounce } from '@/js/hooks/useDebounce'; |
Collaborator
Author
There was a problem hiding this comment.
Debounce and usage are not needed here, as it is handled in parent component
zutigrm
commented
Mar 2, 2026
| onInviteResult, | ||
| isLoading = false, | ||
| } ) { | ||
| const filteredUsers = useMemo( () => { |
Collaborator
Author
There was a problem hiding this comment.
Filtering is handled server side now
zutigrm
commented
Mar 2, 2026
| expect( getByText( 'AuthorUser' ) ).toBeInTheDocument(); | ||
| } ); | ||
|
|
||
| it( 'filters users by name match', () => { |
Collaborator
Author
There was a problem hiding this comment.
Filter related tests are redundant now, as filtering is handled server side
zutigrm
commented
Mar 2, 2026
Comment on lines
-44
to
-46
| useEffect( () => { | ||
| setInputValue( value ); | ||
| }, [ value ] ); |
Collaborator
Author
There was a problem hiding this comment.
No longer needed, because the component is fully controlled (value comes directly from parent, no local inputValue state).
tofumatt
requested changes
Mar 3, 2026
Collaborator
tofumatt
left a comment
tofumatt
left a comment
There was a problem hiding this comment.
I think we can simplify the selector handling and add another test for it here, but otherwise looks good 👍🏻
Comment on lines
+94
to
+97
| // Reuse the current selector result when search is empty to avoid duplicate requests. | ||
| if ( debouncedSearchTerm === '' ) { | ||
| return undefined; | ||
| } |
Collaborator
There was a problem hiding this comment.
This says it's re-using a selector result, but it's just returning undefined here. 🤔
Shouldn't we always be returning the eligible subscribers from below? 🤔
Comment on lines
+90
to
+92
| if ( ! hasOpenedSelectionPanel ) { | ||
| return undefined; | ||
| } |
Collaborator
There was a problem hiding this comment.
Same here re: undefined vs null.
Comment on lines
+164
to
+167
| const eligibleSubscribersForSearchThreshold = | ||
| debouncedSearchTerm === '' | ||
| ? eligibleSubscribers | ||
| : allEligibleSubscribers; |
Collaborator
There was a problem hiding this comment.
If debouncedSearchTerm === '' then the same selector will be used twice and shouldn't actually trigger another request while it's resolving.
I think you can remove the logic here that tries to be "clever" about not using the same selector in multiple places and let WP Data handle it—I think it should prevent duplicate requests 🤔
assets/js/components/email-reporting/InviteOthersToSubscribe/index.test.js
Show resolved
Hide resolved
tofumatt
approved these changes
Mar 4, 2026
Collaborator
tofumatt
left a comment
tofumatt
left a comment
There was a problem hiding this comment.
Awesome, looks great, thanks for adding that test 👍🏻
tofumatt
reviewed
Mar 4, 2026
Collaborator
tofumatt
left a comment
tofumatt
left a comment
There was a problem hiding this comment.
Looks like there's a few merge conflicts to resolve, but after that this is good-to-go 👍🏻
Collaborator
Author
|
Thanks, conflicts resolved |
tofumatt
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses issue:
Relevant technical choices
PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist