Conversation
…ON' type. Update notification type and CTA label based on violation severity.
…VIOLATION' type handling. Update policy violation logic to accommodate new content policy states.
…CTA text based on policy violation state. Adjust test cases to reflect changes in expected button labels.
… with parameters for extreme policy violations.
|
Storybook is ready:
|
|
Build files for 4bdf61f have been deleted. |
nfmohit
requested changes
Mar 4, 2026
Collaborator
nfmohit
left a comment
There was a problem hiding this comment.
Thanks for your work on this, @hussain-t!
I've left some minor feedback. As we're under some time constraints, I'll go ahead and address them myself. I hope that is okay.
Thanks again!
...r-revenue-manager/components/dashboard/RRMSetupSuccessSubtleNotification/PolicyViolation.tsx
Outdated
Show resolved
Hide resolved
...reader-revenue-manager/components/dashboard/RRMSetupSuccessSubtleNotification/index.test.tsx
Outdated
Show resolved
Hide resolved
nfmohit
approved these changes
Mar 4, 2026
Collaborator
nfmohit
left a comment
There was a problem hiding this comment.
LGTM ✅
Note: I've verified that the failing E2E tests in CI are unrelated to the changes in this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses issue:
Relevant technical choices
PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist