Skip to content

Enhancement/#12245 - Show RRM extreme policy violation in success setup notification#12265

Merged
nfmohit merged 9 commits intomainfrom
enhancement/#12245-rrm-extreme-policy-violation
Mar 4, 2026
Merged

Enhancement/#12245 - Show RRM extreme policy violation in success setup notification#12265
nfmohit merged 9 commits intomainfrom
enhancement/#12245-rrm-extreme-policy-violation

Conversation

@hussain-t
Copy link
Collaborator

@hussain-t hussain-t commented Mar 3, 2026

Summary

Addresses issue:

Relevant technical choices

PR Author Checklist

  • My code is tested and passes existing unit tests.
  • My code has an appropriate set of unit tests which all pass.
  • My code is backward-compatible with WordPress 5.2 and PHP 7.4.
  • My code follows the WordPress coding standards.
  • My code has proper inline documentation.
  • I have added a QA Brief on the issue linked above.
  • I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

Do not alter or remove anything below. The following sections will be managed by moderators only.

Code Reviewer Checklist

  • Run the code.
  • Ensure the acceptance criteria are satisfied.
  • Reassess the implementation with the IB.
  • Ensure no unrelated changes are included.
  • Ensure CI checks pass.
  • Check Storybook where applicable.
  • Ensure there is a QA Brief.
  • Ensure there are no unexpected significant changes to file sizes.

Merge Reviewer Checklist

  • Ensure the PR has the correct target branch.
  • Double-check that the PR is okay to be merged.
  • Ensure the corresponding issue has a ZenHub release assigned.
  • Add a changelog message to the issue.

…ON' type.

Update notification type and CTA label based on violation severity.
…VIOLATION' type handling.

Update policy violation logic to accommodate new content policy states.
…CTA text based on policy violation state.

Adjust test cases to reflect changes in expected button labels.
… with parameters for extreme policy violations.
@github-actions
Copy link

github-actions bot commented Mar 3, 2026

Storybook is ready:

@github-actions
Copy link

github-actions bot commented Mar 3, 2026

Build files for 4bdf61f have been deleted.

@hussain-t hussain-t changed the base branch from develop to main March 3, 2026 18:41
Copy link
Collaborator

@nfmohit nfmohit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work on this, @hussain-t!

I've left some minor feedback. As we're under some time constraints, I'll go ahead and address them myself. I hope that is okay.

Thanks again!

Copy link
Collaborator

@nfmohit nfmohit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

Note: I've verified that the failing E2E tests in CI are unrelated to the changes in this PR.

@nfmohit nfmohit merged commit 3a5a76d into main Mar 4, 2026
23 of 25 checks passed
@nfmohit nfmohit deleted the enhancement/#12245-rrm-extreme-policy-violation branch March 4, 2026 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants