Enhancement/#12232 - Remove `rrmPolicyViolations` feature flag by hussain-t · Pull Request #12274 · google/site-kit-wp

hussain-t · 2026-03-04T19:34:32Z

Summary

Addresses issue:

Remove rrmPolicyViolations feature flag #12232

Relevant technical choices

PR Author Checklist

My code is tested and passes existing unit tests.
My code has an appropriate set of unit tests which all pass.
My code is backward-compatible with WordPress 5.2 and PHP 7.4.
My code follows the WordPress coding standards.
My code has proper inline documentation.
I have added a QA Brief on the issue linked above.
I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

Do not alter or remove anything below. The following sections will be managed by moderators only.

Code Reviewer Checklist

Run the code.
Ensure the acceptance criteria are satisfied.
Reassess the implementation with the IB.
Ensure no unrelated changes are included.
Ensure CI checks pass.
Check Storybook where applicable.
Ensure there is a QA Brief.
Ensure there are no unexpected significant changes to file sizes.

Merge Reviewer Checklist

Ensure the PR has the correct target branch.
Double-check that the PR is okay to be merged.
Ensure the corresponding issue has a ZenHub release assigned.
Add a changelog message to the issue.

…nTest.

…ture flag usage.

…olicy status handling.

…, simplifying default settings retrieval.

…lations.

…ontent policy status validation.

…s for Reader Revenue Manager.

…ories.

…otifications.

…n Reader Revenue Manager.

github-actions · 2026-03-04T19:37:40Z

Storybook is ready:

View Storybook

github-actions · 2026-03-04T19:39:51Z

Build files for 3e69c1a have been deleted.

github-actions · 2026-03-04T19:39:56Z

Size Change: -106 B (0%)

Total Size: 2.3 MB

ℹ️ View Unchanged

Filename	Size	Change
`./dist/assets/blocks/reader-revenue-manager/block-editor-plugin/editor-styles.css`	124 B	0 B
`./dist/assets/blocks/reader-revenue-manager/block-editor-plugin/editor-styles.js`	20 B	0 B
`./dist/assets/blocks/reader-revenue-manager/block-editor-plugin/index.js`	42.7 kB	0 B
`./dist/assets/blocks/reader-revenue-manager/common/editor-styles.css`	307 B	0 B
`./dist/assets/blocks/reader-revenue-manager/common/editor-styles.js`	20 B	0 B
`./dist/assets/blocks/reader-revenue-manager/contribute-with-google/index.js`	5.88 kB	0 B
`./dist/assets/blocks/reader-revenue-manager/contribute-with-google/non-site-kit-user.js`	5.07 kB	0 B
`./dist/assets/blocks/reader-revenue-manager/subscribe-with-google/index.js`	5.88 kB	0 B
`./dist/assets/blocks/reader-revenue-manager/subscribe-with-google/non-site-kit-user.js`	5.07 kB	0 B
`./dist/assets/blocks/sign-in-with-google/editor-styles.css`	84 B	0 B
`./dist/assets/blocks/sign-in-with-google/editor-styles.js`	20 B	0 B
`./dist/assets/blocks/sign-in-with-google/index.js`	18.6 kB	0 B
`./dist/assets/css/googlesitekit-admin-css-********************.min.css`	67 kB	0 B
`./dist/assets/css/googlesitekit-adminbar-css-********************.min.css`	12.3 kB	0 B
`./dist/assets/css/googlesitekit-authorize-application-css-********************.min.css`	846 B	0 B
`./dist/assets/css/googlesitekit-wp-dashboard-css-********************.min.css`	8.89 kB	0 B
`./dist/assets/js/146-********************.js`	963 B	0 B
`./dist/assets/js/201-********************.js`	2.85 kB	0 B
`./dist/assets/js/314-********************.js`	100 kB	0 B
`./dist/assets/js/315-********************.js`	3.08 kB	0 B
`./dist/assets/js/379-********************.js`	3.7 kB	0 B
`./dist/assets/js/590-********************.js`	1.89 kB	0 B
`./dist/assets/js/640-********************.js`	2.36 kB	0 B
`./dist/assets/js/909-********************.js`	1.01 kB	0 B
`./dist/assets/js/analytics-advanced-tracking-********************.js`	475 B	0 B
`./dist/assets/js/googlesitekit-activation-********************.js`	25 kB	0 B
`./dist/assets/js/googlesitekit-ad-blocking-recovery-********************.js`	59.3 kB	0 B
`./dist/assets/js/googlesitekit-admin-pointers-tracking-********************.js`	5.35 kB	0 B
`./dist/assets/js/googlesitekit-adminbar-********************.js`	35.8 kB	0 B
`./dist/assets/js/googlesitekit-api-********************.js`	7.99 kB	0 B
`./dist/assets/js/googlesitekit-block-tracking-********************.js`	5.55 kB	0 B
`./dist/assets/js/googlesitekit-components-********************.js`	5.81 kB	0 B
`./dist/assets/js/googlesitekit-consent-mode-********************.js`	25.5 kB	0 B
`./dist/assets/js/googlesitekit-data-********************.js`	1.73 kB	0 B
`./dist/assets/js/googlesitekit-datastore-forms-********************.js`	7.01 kB	0 B
`./dist/assets/js/googlesitekit-datastore-location-********************.js`	1.51 kB	0 B
`./dist/assets/js/googlesitekit-datastore-site-********************.js`	18.1 kB	0 B
`./dist/assets/js/googlesitekit-datastore-ui-********************.js`	7.16 kB	0 B
`./dist/assets/js/googlesitekit-datastore-user-********************.js`	23 kB	0 B
`./dist/assets/js/googlesitekit-entity-dashboard-********************.js`	71.7 kB	0 B
`./dist/assets/js/googlesitekit-events-provider-contact-form-7-********************.js`	1.27 kB	0 B
`./dist/assets/js/googlesitekit-events-provider-easy-digital-downloads-********************.js`	655 B	0 B
`./dist/assets/js/googlesitekit-events-provider-mailchimp-********************.js`	1.27 kB	0 B
`./dist/assets/js/googlesitekit-events-provider-ninja-forms-********************.js`	1.26 kB	0 B
`./dist/assets/js/googlesitekit-events-provider-optin-monster-********************.js`	1.29 kB	0 B
`./dist/assets/js/googlesitekit-events-provider-popup-maker-********************.js`	1.34 kB	0 B
`./dist/assets/js/googlesitekit-events-provider-woocommerce-********************.js`	990 B	0 B
`./dist/assets/js/googlesitekit-events-provider-wpforms-********************.js`	1.29 kB	0 B
`./dist/assets/js/googlesitekit-i18n-********************.js`	6.16 kB	0 B
`./dist/assets/js/googlesitekit-key-metrics-setup-********************.js`	53 kB	0 B
`./dist/assets/js/googlesitekit-main-dashboard-********************.js`	149 kB	0 B
`./dist/assets/js/googlesitekit-metric-selection-********************.js`	57.8 kB	0 B
`./dist/assets/js/googlesitekit-modules-********************.js`	26.3 kB	0 B
`./dist/assets/js/googlesitekit-modules-ads-********************.js`	48.4 kB	0 B
`./dist/assets/js/googlesitekit-modules-adsense-********************.js`	137 kB	0 B
`./dist/assets/js/googlesitekit-modules-analytics-4-********************.js`	190 kB	0 B
`./dist/assets/js/googlesitekit-modules-pagespeed-insights-********************.js`	23.4 kB	0 B
`./dist/assets/js/googlesitekit-modules-reader-revenue-manager-********************.js`	52.5 kB	-106 B (-0.2%)
`./dist/assets/js/googlesitekit-modules-search-console-********************.js`	66.5 kB	0 B
`./dist/assets/js/googlesitekit-modules-sign-in-with-google-********************.js`	33.9 kB	0 B
`./dist/assets/js/googlesitekit-modules-tagmanager-********************.js`	30.4 kB	0 B
`./dist/assets/js/googlesitekit-notifications-********************.js`	68.4 kB	0 B
`./dist/assets/js/googlesitekit-polyfills-********************.js`	230 B	0 B
`./dist/assets/js/googlesitekit-settings-********************.js`	133 kB	0 B
`./dist/assets/js/googlesitekit-splash-********************.js`	78.2 kB	0 B
`./dist/assets/js/googlesitekit-user-input-********************.js`	51.2 kB	0 B
`./dist/assets/js/googlesitekit-vendor-********************.js`	328 kB	0 B
`./dist/assets/js/googlesitekit-widgets-********************.js`	104 kB	0 B
`./dist/assets/js/googlesitekit-wp-dashboard-********************.js`	61.8 kB	0 B
`./dist/assets/js/runtime-********************.js`	1.92 kB	0 B

_{compressed-size-action}

techanvil

Thanks @hussain-t, this is looking good. There are some very minor changes needed, please see my comments.

assets/js/modules/reader-revenue-manager/datastore/settings.test.js

tests/phpunit/integration/Modules/Reader_Revenue_ManagerTest.php

…s-ff.

hussain-t · 2026-03-05T12:28:05Z

Thanks, @techanvil! I've addressed the feedback. Back to you for another pass.

techanvil

Thanks @hussain-t, that LGTM.

✅

Note that I've confirmed the failing E2E tests are unrelated to this PR.

hussain-t added 18 commits March 5, 2026 00:40

Remove feature toggle for policy violations in Synchronize_Publicatio…

c166b8e

…nTest.

Refactor SettingsTest to remove rrmPolicyViolations feature flag.

e063107

Refactor Reader_Revenue_ManagerTest to remove rrmPolicyViolations fea…

d642372

…ture flag usage.

Refactor Synchronize_Publication to remove feature flag for content p…

249355a

…olicy status handling.

Refactor Settings to eliminate feature flag for content policy status…

bf2ffe3

…, simplifying default settings retrieval.

Refactor Reader_Revenue_Manager to remove feature flag for policy vio…

7c29aad

…lations.

Refactor Reader_Revenue_Manager settings tests to remove feature flag.

13a2bf7

Refactor Reader_Revenue_Manager settings to remove feature flag for c…

d27d84f

…ontent policy status validation.

Remove rrmPolicyViolations feature flag from feature-flags.json.

fd27148

Remove usage of rrmPolicyViolations feature flag in publications test…

3e2e69e

…s for Reader Revenue Manager.

Refactor publications.js to eliminate rrmPolicyViolations feature flag.

02211d0

Remove rrmPolicyViolations feature flag in the base datastore.

ed4562e

Remove rrmPolicyViolations feature flag from SettingsView stories.

440678e

Remove rrmPolicyViolations feature flag from SettingsActiveModules st…

7a8d264

…ories.

Remove rrmPolicyViolations feature flag from SettingsEdit stories.

d8c3a7e

Remove rrmPolicyViolations feature flag from Reader Revenue Manager n…

bae394a

…otifications.

Remove rrmPolicyViolations feature flag from SettingsForm component i…

c34c203

…n Reader Revenue Manager.

Remove rrmPolicyViolations feature flag from SettingsView component i…

f638371

…n Reader Revenue Manager.

hussain-t added 3 commits March 5, 2026 01:32

Add contentPolicyStatus to settings in SetupForm tests.

c75f26d

Add contentPolicyStatus to settings in SetupMain tests.

15b54fd

Add contentPolicyState to debug fields in Reader Revenue Manager tests.

750aba3

techanvil requested changes Mar 5, 2026

View reviewed changes

hussain-t added 3 commits March 5, 2026 17:07

Merge branch 'main' into enhancement/#12232-remove-rrmPolicyViolation…

26f7bac

…s-ff.

Remove dynamic imports in Reader Revenue Manager settings.

d10efe2

Imporve comments.

3e69c1a

techanvil approved these changes Mar 5, 2026

View reviewed changes

techanvil merged commit c985dfc into main Mar 5, 2026
32 of 33 checks passed

techanvil deleted the enhancement/#12232-remove-rrmPolicyViolations-ff branch March 5, 2026 13:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enhancement/#12232 - Remove `rrmPolicyViolations` feature flag#12274

Enhancement/#12232 - Remove `rrmPolicyViolations` feature flag#12274
techanvil merged 24 commits intomainfrom
enhancement/#12232-remove-rrmPolicyViolations-ff

hussain-t commented Mar 4, 2026 •

edited by techanvil

Loading

Uh oh!

github-actions bot commented Mar 4, 2026

Uh oh!

github-actions bot commented Mar 4, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Mar 4, 2026 •

edited

Loading

Uh oh!

techanvil left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hussain-t commented Mar 5, 2026

Uh oh!

techanvil left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

hussain-t commented Mar 4, 2026 • edited by techanvil Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Relevant technical choices

PR Author Checklist

Code Reviewer Checklist

Merge Reviewer Checklist

Uh oh!

github-actions bot commented Mar 4, 2026

Uh oh!

github-actions bot commented Mar 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Mar 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

techanvil left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hussain-t commented Mar 5, 2026

Uh oh!

techanvil left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

hussain-t commented Mar 4, 2026 •

edited by techanvil

Loading

github-actions bot commented Mar 4, 2026 •

edited

Loading

github-actions bot commented Mar 4, 2026 •

edited

Loading