Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced HTTP where HTTPS was available #118

Merged
merged 3 commits into from
Apr 27, 2016
Merged

Replaced HTTP where HTTPS was available #118

merged 3 commits into from
Apr 27, 2016

Conversation

yackermann
Copy link
Contributor

I found that most of the links in current style guide still been using HTTP. I went through all HTTP links and those that had supported HTTPS been replaces with HTTPS version.

4 links about VIM been using goo.gl link shortening(https://goo.gl/CUXJZC). I have replaced them with actual link.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@yackermann
Copy link
Contributor Author

I signed it!

2016-04-01 21:48 GMT+13:00 googlebot [email protected]:

Thanks for your pull request. It looks like this may be your first
contribution to a Google open source project. Before we can look at your
pull request, you'll need to sign a Contributor License Agreement (CLA).

[image: 📝] Please visit https://cla.developers.google.com/
https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll

verify. Thanks.


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#118 (comment)

@googlebot
Copy link

CLAs look good, thanks!

@@ -1,5 +1,5 @@
This is automated checker to make sure a C++ file follows Google's C++ style
guide (http://google.github.io/styleguide/cppguide.html). As it
guide [https://google.github.io/styleguide/cppguide.html](https://google.github.io/styleguide/cppguide.html). As it
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem to be a Markdown file, so I don't think it should have Markdown-style links.

@yackermann
Copy link
Contributor Author

@geoffromer Ooops. True XD

@yackermann
Copy link
Contributor Author

@geoffromer Done!*)

@geoffromer geoffromer merged commit 8a3b573 into google:gh-pages Apr 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants